perf(zerozone): smooth the commit #3080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Han <[email protected]>
superhx
requested review from
1sonofqiu,
Gezi-lzq and
woshigaopp
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the performance of the commit operation in the zerozone feature by implementing a "smooth commit" strategy. The changes optimize commit behavior to reduce latency while maintaining data consistency.
Key changes:
- Modified AsyncNetworkBandwidthLimiter to complete futures outside of locks, improving concurrency
- Refactored S3Storage's LazyCommit to support separate completion futures for trim and commit operations
- Enhanced PartitionSnapshotsManager to use delayed commits (1000ms) for non-initial requests, optimizing performance
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AsyncNetworkBandwidthLimiter.java | Moves CompletableFuture completion outside the lock to avoid holding locks during callback execution |
| S3Storage.java | Splits LazyCommit's single CompletableFuture into separate trimCf and commitCf for better control over completion semantics |
| PartitionSnapshotsManager.java | Implements differential commit behavior: immediate (0ms) for new sessions, delayed (1000ms) for subsequent requests to smooth commits |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenzhu
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #3079