Forms: hide trash as primary action on mobile

[simison]

Follow-up to #45597 (comment)

Proposed changes:

• While waiting for next release of dataviews with Update: Hide primary action buttons on mobile WordPress/gutenberg#72597, we can hide the "trash" action already to give the list more space; in next version of dataviews it'll get hidden so we can revert this change.
• We need to keep the "view" action there as it's the only quick way currently to open responses on mobile, but we'll change that.

Before

After

Desktop stays as-is:

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Trash action in rows gone on mobile, but available on multi-actions and dropdown
• Trash action visible on desktop

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-hide-trash-action-mobile branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-hide-trash-action-mobile

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[CGastrell]

Is this just outdated? I thought we added this sometime ago

[simison]

Just rebased 👍

[CGastrell]

LGTM! Just FYI, a test has been added but just to verify the actions menu is there and there's a Trash button in it: Automattic/wp-calypso#106689

I'll let you check this with @ilonagl

[simison]

Thanks for handling the test! We talked about the design side of this today in a call already.

[ilonagl]

thanks for the ping! It looks good. I wonder if we should default to icons for bulk actions on mobile?

[simison]

We reverted DataViews 10.1.0 so this wasn't needed yet: #45624

But will be needed for the next attempt: #45625

[dhasilva]

This will conflict with #45670
Can we add the changes there instead?

[simison]

Yass, I'll close this one and let you continue :-)