Skip to content

Conversation

@anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 3, 2025

Closes MONOREP-176

Proposed changes:

Since 147-ghe-Automattic/pre-receive-hooks, 130_stop_executables runs on modified files too, but only prevents changing them to be executable (not existing executables).

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try making a PR based on this one that changes an existing file (that makes it into Jetpack or jetpack-mu-wpcom-plugin) executable. See if the appropriate Post-Build check fails.

Since 147-ghe-Automattic/pre-receive-hooks, 130_stop_executables runs on
modified files too.
@anomiex anomiex requested a review from a team November 3, 2025 18:37
@anomiex anomiex self-assigned this Nov 3, 2025
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@anomiex anomiex merged commit 513e285 into trunk Nov 3, 2025
67 checks passed
@anomiex anomiex deleted the update/wpcom-filename-restrictions branch November 3, 2025 19:52
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants