Update dependency scssphp/scssphp to v2 #45757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
[Status] Needs Review
Contributor
Author
|
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Renovate failure aside, I realized too late that this requires PHP 8.1+. 😢 |
tbradsha
changed the title
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Contributor
We may be able to do this. While And as for jetpack/projects/packages/jetpack-mu-wpcom/composer.json Lines 6 to 7 in 9bf43b4 |
matticbot
force-pushed
the
renovate/scssphp-scssphp-2.x
branch
from
6069946 to
c6aaa11
Compare
matticbot
changed the title
github-actions
bot
added
[Plugin] Jetpack
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
tbradsha
approved these changes
Nov 18, 2025
Contributor
tbradsha
left a comment
tbradsha
left a comment
There was a problem hiding this comment.
Seems to work on WoW and Simple for me. As mentioned inline, I don't think we need to keep it at PHP 8.1 unless you want to.
Comment on lines
+6
to
+8
| "_comment": [ | ||
| "Dependency on symfony/filesystem is so scssphp/scssphp doesn't bring in 7.x which requires PHP 8.2." | ||
| ], |
Contributor
There was a problem hiding this comment.
I think we should be safe to switch to >= PHP 8.2 for this specific feature.
Contributor
There was a problem hiding this comment.
I asked the Atomic team, and they weren't sure that some of the remaining 8.1 sites in the "internal" group weren't using wpcomsh. So to be safe, let's stick with 8.1 for now until they give the all-clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.13.0->2.0.1Release Notes
scssphp/scssphp (scssphp/scssphp)
v2.0.1: 2.0.1Compare Source
Fixed
v2.0.0: 2.0.0Compare Source
This release is a full rewrite of the compiler. The new implementation is a port of dart-sass,
making it spec-compliant and easier to update to support new Sass features. However this release
does not implement Sass modules yet.
BC breaks
Compilerclass is now finalLoggerInterfacenow expects more argument in its method signatures\ScssPhp\ScssPhp\OutputStyleis now an enum instead of a class with string constants.Compiler::setOutputStylenow expects an instance of theOutputStyleenum instead of a string.Deprecated
Compiler::compileStringsecond argument. Either passa URL or use
Compiler::compileFileinstead. (@stof)Removed
scss.inc.phpfile. Use the autoloader generated by Composer instead. (@stof)Added
Importerextension point for custom importers (@stof)Compiler::setSilencedDeprecations,Compiler::setFutureDeprecationsandCompiler::setActiveDeprecations(@stof)Compiler::setQuietDeps(@stof)Compiler::setVerbose(@stof)Fixed
Changed
need to include them based on the provided argument depending on their formatting needs. (@stof)
\ScssPhp\ScssPhp\Value\Valueas return type. Untyped functions will still receive legacyvalues. (@stof)
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 02:59 AM, on day 1 of the month ( * 0-2 1 * * ) in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.