lesson video allow html tag change with default wp kses

[bhavik-dreamz]

Fixes #

Changes proposed in this Pull Request:

• i am getting issue with video allow html tags
  I have replaced allowed_html tag with default kses_allowed_html with the same structure

Testing instructions:

• please check in allowed_html in file class-sensi-lesson.php and class-sensi fronted.php both are different so i make same like class-sensi-lesson.php in class-sensi fronted.php

Screenshot / Video

Proposed changelog entry for your changes:

[donnapep]

Further to my comment below, we should fix the Video Embed Code field of the lesson in the editor, so that custom HTML can be saved there too.

[donnapep]

I think we should consider also allowing any tags here that wp_kses_post allows:

$this->allowed_html = array_merge( Sensei_Wp_Kses::get_default_wp_kses_allowed_html(), wp_kses_allowed_html( 'post' ) );

[bhavik-dreamz]

i think you are right but this is a field for any video so we can't allow other tags, i thing does'e need to allow wp_kses_allowed_html( 'post' ),

[bhavik-dreamz]

updateds now #2992

[donnapep]

I disagree. For example, Vimeo embeds include HTML tags like <p> and <a> that would be stripped out by this.

Besides, if we're allowing people to save HTML in the video embed code for a lesson in WP Admin, but then don't display it on the front-end, what's the point?

[jmalko]

The code that is in place presently prevents me from using a video host outside of YouTube, Vimeo, or Self-host. I happen to use a service called Wistia and have made workarounds in my templates in order to be able to embed videos. When I want to "allow HTML", there is a good reason for it.

The solution offered here would be both what would work and what I would expect with such a feature.