Skip to content

Unify add site props #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
sejas wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Unify add site props #2246

sejas wants to merge 2 commits into from
+94 −229

Conversation

@sejas
Copy link
Member

@sejas sejas commented Dec 12, 2025

Related issues

Proposed Changes

  • This PR doesn't add new functionality. It just simplifies the prop drilling to use only one prop. In future refactors we can consider using a Redux slice to remove the addSiteProps prop too.

Testing Instructions

  • This PR doesn't add or modify any feature. We need to confirm there are no regressions.
  • Run npm start
  • Click on Add site
  • Try the four options
  • Confirm there are no regressions

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sejas sejas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sejas