Ensure all CLI commands can be aborted #2282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekelund
commented
Dec 18, 2025
Comment on lines
-63
to
-66
| process.on( 'exit', disconnect ); | ||
| process.on( 'SIGINT', disconnect ); | ||
| process.on( 'SIGTERM', disconnect ); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This isn't necessary. API consumers should be responsible for connecting and disconnecting from pm2. In fact, this previously resulted in a race condition where the abort message I implemented in this PR wouldn't be delivered (because the process disconnected from the pm2 daemon before sending it).
fredrikekelund
commented
Dec 18, 2025
|
|
||
| const managerMessageStopServer = z.object( { | ||
| topic: z.literal( 'stop-server' ), | ||
| data: z.object( {} ), |
Contributor
Author
There was a problem hiding this comment.
pm2 requires all messages to have id, topic, and data fields. We didn't notice that the stop-server topic would generate errors because stopWordPressServer swallows exceptions.
fredrikekelund
changed the title
bcotrim
approved these changes
Dec 19, 2025
Contributor
bcotrim
left a comment
bcotrim
left a comment
There was a problem hiding this comment.
LGTM as works as described 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
AbortControllerincli/lib/wordpress-server-manager.tsthat interruptssendMessagepromises, ensuring that the CLI process exits when it receives aSIGINTorSIGTERM(Ctrl+C)abortIPC message topic that aborts async operations incli/lib/types/wordpress-server-ipc.ts(most oftenly killing the process). We'll refine this behavior once Re-enable WP-CLI execution in the child process #2261 has landed.Testing Instructions
npm run cli:buildnode dist/cli/main.js site create --path PATH_TO_SITEwherePATH_TO_SITEis the path to a new folder where the site should be createdStarting WordPress serverstage, press Ctrl+CPre-merge Checklist