Fix stuck tooltips #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2017 11:25
Despite krispo#172 had been solved in case of changing data, bu it is stil happening when change options. Set the option useInteractiveGuideline true. After populate data, change the current options like tickFormat. This only happens with useInteractiveGuideline=true.
Conflicts: dist/angular-nvd3.min.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug found on
angular-nvd3causing tooltips to remain on the DOM after hovering out on a chart (yes multiple tooltip instances!). The result would be multiple tooltips stuck in the middle of the screen floating above everything on the screen (as they are attached to the body and absolutely positioned in nvd3) even after destroying a chart.I found a contributor fix on PR krispo#616. Since it hasn't been merged into the
masterbranch on the upstream repo I have decided to merge his branch into ours.