feat: add password account contract and custom note contract #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critesjosh
reviewed
Nov 10, 2025
| { | ||
| "name": "account-contract", | ||
| "type": "module", | ||
| "scripts": {}, |
Contributor
There was a problem hiding this comment.
I removed the scripts since it looks like they were for another project. Are there scripts we'd want to add here? Maybe an example of using this account contract to send a transaction, or is it similar enough that it isn't helpful to show?
critesjosh
reviewed
Nov 10, 2025
Contributor
There was a problem hiding this comment.
I also added this w/ Claude. Can you skim and confirm it's accurate?
Contributor
There was a problem hiding this comment.
It would also be helpful to provide some pointers for things to look out for, for readers that are looking to implement their own account contracts. We have very little documentation or implementation details about how to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.