chore(deps): upgrade ESLint from v8 to v9#8769
Open
dependabot[bot] wants to merge 2 commits intomainfrom
Open
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
❌ Risk Level
Notes to help justify risk level:
✅ What & Why
Also note: I found a test/spec change in the diff: libs/designer-v2/.../TreeActionItem.spec.tsx changed expected text from matching
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Title is fine; optional: include versions in title for clarity. |
| Commit Type | ✅ | Correctly selected chore. |
| Risk Level | ❌ | Change label to risk:medium or expand PR body to justify Low (explain Node engine compatibility, CI success, no runtime changes). |
| What & Why | ✅ | Add explicit mention of files changed and Node engine/CI considerations. |
| Impact of Change | Expand Developer/System impact details (lint behavior, Node engines, CI jobs). | |
| Test Plan | Add concrete test/verifications (CI job names/links, local commands and outcomes). Explain why unit/E2E tests were not added. | |
| Contributors | ✅ | Dependabot noted — OK. |
| Screenshots/Videos | ✅ | N/A - ok for non-visual change. |
Final notes & actions required:
- Risk label mismatch: please change the PR label from
risk:lowtorisk:medium, or update the PR body to justify keepingLow(explicitly show CI passes and state why the change is safe for all developers and systems). I recommendrisk:mediumgiven the major ESLint bump and extensive lockfile changes. - Update the Test Plan section with the exact CI job(s) that passed and the commands you ran locally to validate (include outcomes). If you relied on CI, include the job names and an assertion the new linter rules were executed/green.
- Add a short note in What & Why and Impact of Change stating whether Node engine requirements changed for developers/CI and whether any machines need Node version upgrades.
- Mention the test change (TreeActionItem.spec.tsx: expected value changed to
5s) and the reason for that change. - If there are any manual changes required to the ESLint config after this upgrade (rule changes, removals), either make them or list them as follow-up work.
Once you make these small updates (risk label or justification, expanded Test Plan, Node/caveats notes), re-run CI and update the PR so reviewers can quickly re-check. Thank you for keeping dependencies up to date — these details will help reviewers and maintainers accept the change with confidence.
Last updated: Thu, 05 Feb 2026 16:27:53 GMT
|
📊 Coverage check completed. See workflow run for details. |
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 9.26.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/v9.26.0/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.1...v9.26.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.26.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
63d31cc to
18a429f
Compare
|
📊 Coverage check completed. See workflow run for details. |
ccastrotrejo
approved these changes
Feb 5, 2026
|
📊 Coverage check completed. See workflow run for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
This PR upgrades ESLint from version 8.57.1 to 9.26.0, a major version upgrade. ESLint v9 includes:
no-empty-function,no-unused-expressions,no-invalid-this,no-loop-func)reportGlobalThisforno-shadow-restricted-names, suggestions foreqeqeq,ignoreDirectivesoption inno-unused-expressionsThis upgrade ensures we stay current with the latest linting capabilities and security patches.
Impact of Change
Test Plan
Contributors
Auto-generated by Dependabot
Screenshots/Videos
N/A - No visual changes