[PS] migrate ActivityLogAlert in Monitor module to autorest v4 #28024
+481
−357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
JoyerJin
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the ActivityLogAlert module in Azure PowerShell Monitor to AutoRest v4, updating the code generation tooling and introducing new features while maintaining backward compatibility through breaking change exceptions.
- Upgraded AutoRest version from 3.x to 4.x for improved code generation
- Added new JSON-based parameter sets for cmdlets (JsonFilePath and JsonString)
- Introduced breaking change exceptions for type compatibility between array and List types
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/StaticAnalysis/Exceptions/Az.Monitor/BreakingChangeIssues.csv | Added breaking change exceptions for type changes from arrays to generic Lists |
| src/Monitor/Monitor/help/*.md | Updated help documentation with new parameter sets and corrected namespace references |
| src/Monitor/Monitor/ChangeLog.md | Added changelog entry referencing AutoRest v4 new features |
| src/Monitor/Monitor/Az.Monitor.psd1 | Updated generation date and corrected MetricData assembly reference |
| src/Monitor/Monitor.sln | Reorganized project references and updated GUIDs |
| src/Monitor/ActivityLogAlert.Autorest/test/* | Updated test environment and utilities for new ActionGroup creation pattern |
| src/Monitor/ActivityLogAlert.Autorest/README.md | Simplified configuration by removing v3.x extensions and breaking change directives |
| src/Monitor/ActivityLogAlert.Autorest/custom/*.ps1 | Updated cmdlets to support new parameter sets and corrected type references |
src/Monitor/ActivityLogAlert.Autorest/custom/Update-AzActivityLogAlert.ps1
Show resolved
Hide resolved
Fix Project information missing
isra-fel
added
the
autorest v4 migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.