Skip to content

Conversation

@JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Jul 1, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JoyerJin JoyerJin changed the title [PS] Migrate ActivityLogAlert module to autorest v4 [PS] Migrate AutoScale module to autorest v4 Jul 1, 2025
@JoyerJin JoyerJin changed the title [PS] Migrate AutoScale module to autorest v4 [PS] Migrate AutoScale in Monitor module to autorest v4 Jul 17, 2025
@JoyerJin JoyerJin added the Contains Breaking Change This PR contains breaking change label Aug 7, 2025
@JoyerJin JoyerJin marked this pull request as ready for review August 7, 2025 09:19
Copilot AI review requested due to automatic review settings August 7, 2025 09:19
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request migrates the AutoScale module in Monitor to autorest v4, bringing breaking changes to maintain consistency with the new autorest version. The migration involves updating API generation patterns, parameter types, and documentation formats.

  • Migration from autorest v3 to v4 with breaking changes to property types and parameter signatures
  • Updated parameter types from specific enum types to string types for better flexibility
  • Removed deprecated administrator notification parameters due to Azure classic administrator retirement

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/StaticAnalysis/Exceptions/Az.Monitor/BreakingChangeIssues.csv Adds breaking change exceptions for type changes from enums to strings and arrays to lists
src/Monitor/Monitor/help/*.md Updates help documentation to reflect new parameter types and remove API version references
src/Monitor/Monitor/ChangeLog.md Documents retirement of classic administrator notification parameters
src/Monitor/Monitor.sln Reorders project references in solution file
src/Monitor/Autoscale.Autorest/test/* Updates test files with new environment configuration and removes deprecated parameters
src/Monitor/Autoscale.Autorest/docs/*.md Updates documentation to reflect new parameter types and URLs
src/Monitor/Autoscale.Autorest/custom/*.ps1 Updates custom cmdlet implementations with new type signatures
src/Monitor/Autoscale.Autorest/README.md Simplifies autorest configuration and removes breaking change directives

@isra-fel isra-fel added the autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 Contains Breaking Change This PR contains breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants