Skip to content

Conversation

@lijinpei2008
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@lijinpei2008
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@lijinpei2008
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@lijinpei2008 lijinpei2008 added the Contains Breaking Change This PR contains breaking change label Aug 18, 2025
@github-actions
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@lijinpei2008 lijinpei2008 marked this pull request as ready for review August 22, 2025 10:33
Copilot AI review requested due to automatic review settings August 22, 2025 10:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Automanage module to use AutoRest PowerShell v4 instead of v3, resulting in significant changes to the generated cmdlets and documentation. The upgrade brings enhanced functionality including new Update cmdlets and improved parameter sets while maintaining backward compatibility through breaking change exceptions.

Key changes:

  • Upgrade from AutoRest PowerShell v3 to v4 for improved code generation
  • Addition of three new Update cmdlets for configuration profile assignments
  • Enhanced parameter sets with JSON input support across multiple cmdlets

Reviewed Changes

Copilot reviewed 53 out of 53 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/StaticAnalysis/Exceptions/Az.Automanage/BreakingChangeIssues.csv Added breaking change exceptions to handle property type changes from v3 to v4
src/Automanage/Automanage/help/*.md Updated help documentation with new parameter sets and corrected output types
src/Automanage/Automanage/Az.Automanage.psd1 Added three new Update cmdlets to module exports
src/Automanage/Automanage.sln Updated project GUID reference for AutoRest project
src/Automanage/Automanage.Autorest/test/*.Tests.ps1 Added test files for new Update cmdlets
src/Automanage/Automanage.Autorest/generate-info.json Updated generation ID for new AutoRest run
src/Automanage/Automanage.Autorest/examples/*.md Added example documentation for new Update cmdlets
src/Automanage/Automanage.Autorest/docs/*.md Updated AutoRest documentation with new parameter sets and output types
src/Automanage/Automanage.Autorest/README.md Removed v3-specific configuration and updated directive patterns

```

### -ClusterName
The name of the Arc machine.
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter description for ClusterName incorrectly states 'The name of the Arc machine.' but should be 'The name of the AzureStackHCI cluster.' to match the cmdlet's purpose for HCI cluster assignments.

Suggested change
The name of the Arc machine.
The name of the AzureStackHCI cluster.

Copilot uses AI. Check for mistakes.
```

### -ClusterName
The name of the Arc machine.
Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter description for ClusterName incorrectly states 'The name of the Arc machine.' but should be 'The name of the AzureStackHCI cluster.' to match the cmdlet's purpose for HCI cluster assignments.

Suggested change
The name of the Arc machine.
The name of the AzureStackHCI cluster.

Copilot uses AI. Check for mistakes.
@isra-fel
Copy link
Member

isra-fel commented Sep 2, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@isra-fel isra-fel added the autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 label Oct 2, 2025
@dolauli dolauli added the Breaking change PR reviewed Add this label after a PR with breaking change has been reviewed and approved. label Oct 28, 2025
@dolauli dolauli self-assigned this Oct 28, 2025
@dolauli dolauli merged commit 4f82022 into main Oct 30, 2025
14 checks passed
@dolauli dolauli added this to the Az 15.0.0 (11/18/2025) milestone Oct 30, 2025
@lijinpei2008 lijinpei2008 deleted the jinpei/main/Automanage-v4 branch November 3, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 Breaking change PR reviewed Add this label after a PR with breaking change has been reviewed and approved. Contains Breaking Change This PR contains breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants