migrate workloads sapVirtualInstance to autorest v4 #28275
+3,192
−928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Pan-Qi
force-pushed
the
bernard-migrate-workloads-sapVirtualInstance-to-autorest-v4
branch
from
47720a9 to
cda9130
Compare
Pan-Qi
force-pushed
the
bernard-migrate-workloads-sapVirtualInstance-to-autorest-v4
branch
from
cda9130 to
9f67c13
Compare
|
To the author of the pull request, |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Azure PowerShell Workloads SapVirtualInstance module to AutoRest v4, introducing breaking changes primarily around identity management and parameter handling for cmdlets. The key changes include simplifying managed identity configuration, updating parameter types from enums to strings, and adding new parameter sets for JSON input.
- Upgraded SapVirtualInstance module from AutoRest v3 to v4
- Simplified managed identity configuration with new parameters
- Added comprehensive breaking change exception tracking
Reviewed Changes
Copilot reviewed 70 out of 78 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tools/StaticAnalysis/Exceptions/Az.Workloads/BreakingChangeIssues.csv |
Added comprehensive breaking change exception tracking for 142 type changes |
src/Workloads/Workloads/help/*.md |
Updated cmdlet help documentation reflecting new parameter structures and types |
src/Workloads/Workloads/ChangeLog.md |
Documented breaking changes in managed identity parameters |
src/Workloads/Workloads/Az.Workloads.psd1 |
Updated module dependencies and generation date |
src/Workloads/SapVirtualInstance.Autorest/test/*.Tests.ps1 |
Updated test scripts to use new simplified identity parameters |
| ``` | ||
|
|
||
| In this example, you Install the SAP software on the deployed infrastructure for a three tier distributed Highly Available SAP system with Transport directory and customized resource naming. | ||
| In this example, you Install the SAP software on the deployed infrastructure for a three tier distributed Highly Availabile SAP system with Transport directory and customized resource naming. |
There was a problem hiding this comment.
The word 'Availabile' is misspelled. It should be 'Available'.
Suggested change
| In this example, you Install the SAP software on the deployed infrastructure for a three tier distributed Highly Availabile SAP system with Transport directory and customized resource naming. | |
| In this example, you Install the SAP software on the deployed infrastructure for a three tier distributed Highly Available SAP system with Transport directory and customized resource naming. |
| Learn More: https://go.microsoft.com/fwlink/?linkid=2256933 | ||
|
|
||
| ### Example 7: Deploy infrastructure for a three-tier distributed Highly Available (HA) SAP system with Azure Compute Gallery Image | ||
| ### Example 7: Deploy infrastructure for a three-tier distributed Highly Available (HA) SAP system with Azure Compute Gallary Image |
There was a problem hiding this comment.
The word 'Gallary' is misspelled. It should be 'Gallery'.
Suggested change
| ### Example 7: Deploy infrastructure for a three-tier distributed Highly Available (HA) SAP system with Azure Compute Gallary Image | |
| ### Example 7: Deploy infrastructure for a three-tier distributed Highly Available (HA) SAP system with Azure Compute Gallery Image |
| ``` | ||
|
|
||
| In this example, you Deploy infrastructure for a three-tier distributed Highly Available (HA) SAP system with Azure Compute Gallery Image. | ||
| In this example, you Deploy infrastructure for a three-tier distributed Highly Available (HA) SAP system with Azure Compute Gallary Image. |
There was a problem hiding this comment.
The word 'Gallary' is misspelled. It should be 'Gallery'.
isra-fel
added
the
autorest v4 migration
6 tasks
|
Test recordings are in #28275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please also review and merge pr for test recording
#28647
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.