make source list optional for redistribute throughput API #28561

lnajaroen · 2025-09-15T23:21:58Z

Description

Update existing API. Make source list optional for redistribute throughput API. Currently it throws error if list is null and not passed through. We now support empty source list.

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

…24165) * apply Az.CosmosDB-preview branch CosmosDB folder to this branch * Use autorest.powershell to generate management SDK for cosmosDB (Azure#22413) * remove the custom code since character case change is not treated as a breaking change (Azure#22500) * regen sdk * specify header type as string to fix build error * update autorest file to align with main; regen sdk * fix casing * [Cosmos DB] Powershell changes for 2023-03-15 stable API (Azure#21990) * added tests for listconnectionstrings; updated changelog * add changes for list connection strings response * re-record test * update changelog * Add location api changes * Added test recording for location api * re-record tests * re-record tests * Revert "add changes for list connection strings response" This reverts commit ff3ef0a. * update changelog, update and re-record account tests --------- Co-authored-by: Udit Singh <[email protected]> * CosmosDB - New Restore Parameter (Azure#22585) * restore new param public network access * minor fixes * test change * stable changes 1 * md param def changed * reverting test changes for build * restore ts * test and test recording * CosmosDB 2023-09-15 release (Azure#22726) (Azure#22953) * genrated changes * help and changelog and test case update * Powershell model changes for burst capacity * added customer managed key status to PSDatabaseAccountGetResults.cs * added recording for MongoOperationsTests and SqlOperationsTest * added recording for remaining tests * rerecorded failed tests * added changes in tests * Minimal Tls version for create and update * fixed build errors * updated tls version in test * updated commit id * MinimalTlsVersion to changelog * Update ChangeLog.md Added CustomerManagedKeyStatus to the Changelog * mask 'primaryReadOnlyMasterKey' and 'secondaryReadOnlyMasterKey' in recorded test * mask 'primaryMasterKey' and 'secondaryMasterKey' in recorded test * rerecorded account tests * rerecorded account tests * rerecorded Cassandra tests * re-recorded all but mongo and restore tests --------- Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: Adrián Sibaja Retana <[email protected]> Co-authored-by: unknown <[email protected]> Co-authored-by: AdrianSibajaRetana <[email protected]> * [CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin (Azure#23666) * changes and generated code * update tests * update session records * update help files * update changelog * update session records * update TestUpdateCosmosDBAccountBackupPolicyToContinuous30Days session record * update session records * add notimestamp tests and update few old session records * regen sdk, fix build error * fix duplicate code * nit fix restore tests * re-record tests * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account (Azure#21736) * Merge branch 'Az.CosmosDB-preview' of https://github.com/SrinikhilReddy/azure-powershell into features/users/nanarava/enablepmerge * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * Update src/CosmosDB/CosmosDB/ChangeLog.md Co-authored-by: Jin Lei <[email protected]> * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account. * Update ChangeLog.md Remove duplicate line * Resolve code comments. --------- Co-authored-by: Jin Lei <[email protected]> * Replace Start-Sleep with Start-TestSleep for all test cases (Azure#23780) * re-record account test * fix typo * [Cosmos DB] Powershell changes for 2023-04-15 stable API (Continuous 7 GA) (Azure#21685) * move to new swagger version and prereq * edit readme.md * manually generated from autorest * Continuous 7 days change * add 2 new test recordings * fix example issues * add all test recordings for RestoreTests suite * fix New-AzCosmosDBAccount.md * add almost all test recordings * add 4 more successful recordings. all working now * no examples * clean up help file * add output type to cmdlet * suppress errors for existing cmdlets * Revert "suppress errors for existing cmdlets" This reverts commit f36e275. * suppress static validation errors for existing commands --------- Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Udit Singh <[email protected]> Co-authored-by: mayankkatwal <[email protected]> Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: Richa Sharma <[email protected]> Co-authored-by: Adrián Sibaja Retana <[email protected]> Co-authored-by: unknown <[email protected]> Co-authored-by: AdrianSibajaRetana <[email protected]> Co-authored-by: ddhamotharan <[email protected]> Co-authored-by: Srinikhil Naravamakula <[email protected]> Co-authored-by: Jin Lei <[email protected]> Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: vinhms <[email protected]>

* cherry-pick stable change into preview; stable:Azure#24199 * 1 out of 7 fixed * fixing other 2 tests * fixing remaining 4 tests failure due to session record

…re#24261) * update and regen for 02-15-2024-preview version * code changes * test recording * re-record tests * regen sdk * rerecord tests * test recording * Update ChangeLog.md * Add DisableTtl * Update md file * Introduce custom model class DisableTtl to accomodate enumness * Update readme * Update test json file to expect string instead of bool * Update readme to have boolean to string * Revert back to boolean parameter * Remove bak file * Update restore test * Update restore test * Undo recording file change * Add missing copy in the constructor * Fix spaceing * rerecord test --------- Co-authored-by: Kushal Warke <[email protected]> Co-authored-by: Min Ho Kang <[email protected]>

[DoNotSquash] Get Az.CosmosDB-preview branch up to date

…owershell into azure_preview

…o azure_preview

…review [CosmosDB] Sync main to CosmosDB preview

[CosmosDB] Sync main to CosmosDB preview

Co-authored-by: lijinpei2008 <[email protected]> Co-authored-by: Gandharv Sachdeva <[email protected]> Co-authored-by: gansach <[email protected]> Co-authored-by: Azure PowerShell <[email protected]> Co-authored-by: Yunchi Wang <[email protected]> Co-authored-by: EmmaZhu-MSFT <[email protected]> Co-authored-by: Prajjwal Kamboj <[email protected]> Co-authored-by: Xiaogang <[email protected]> Co-authored-by: Jin Lei <[email protected]> Co-authored-by: Yabo Hu <[email protected]> Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: Prajjwal Kamboj <[email protected]> Co-authored-by: Ankit Baluni <[email protected]> Co-authored-by: Ankit Baluni (from Dev Box) <[email protected]> Co-authored-by: Eugenio Peña García <[email protected]> Co-authored-by: Himanshu Agarwal <[email protected]> Co-authored-by: Karthik Gumpu <[email protected]> Co-authored-by: Karthik Gumpu (from Dev Box) <[email protected]> Co-authored-by: JoyerJin <[email protected]> Co-authored-by: Jingshu918 <[email protected]> Co-authored-by: ShawnX <[email protected]> Co-authored-by: mmkiran21-git <[email protected]> Co-authored-by: kumarutkarsh3b2166 <[email protected]> Co-authored-by: NoriZC <[email protected]> Co-authored-by: Auðunn <[email protected]> Co-authored-by: Sam Lee <[email protected]> Co-authored-by: Sam Lee <[email protected]> Co-authored-by: Yan Xu <[email protected]> Co-authored-by: yashikajain14 <[email protected]> Co-authored-by: Mike F. Robbins <[email protected]> Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Yeming Liu <[email protected]> Co-authored-by: Yeming Liu <[email protected]> Co-authored-by: yanivha6 <[email protected]> Co-authored-by: Yaniv Haddad <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Qi Pan <[email protected]> Co-authored-by: Arie Heinrich <[email protected]> Co-authored-by: Wei Wei <[email protected]> Co-authored-by: Ana Arias Rosales <[email protected]> Co-authored-by: Srinivas <[email protected]> Co-authored-by: Srinivas Alluri <[email protected]> Co-authored-by: Aditya Pujara <[email protected]> Co-authored-by: v-sapanchal <[email protected]> Co-authored-by: yk <[email protected]> Co-authored-by: Yukun Li (Beyondsoft) <[email protected]> Co-authored-by: Faizan Uddin Fahad Khan <[email protected]> Co-authored-by: Faizan Uddin Fahad Khan <[email protected]> Co-authored-by: emmeliaAra <[email protected]> Co-authored-by: emmeliaAra <[email protected]> Co-authored-by: ajtms <[email protected]> Co-authored-by: Christopher Lewis <[email protected]> Co-authored-by: mihretkidane-OCI <[email protected]> Co-authored-by: raghumetta <[email protected]> Co-authored-by: Emily Hua <[email protected]> Co-authored-by: Mathias Foster <[email protected]> Co-authored-by: mfoster58 <[email protected]> Co-authored-by: Anna Pankiewicz <[email protected]> Co-authored-by: prakhar_shukla <[email protected]> Co-authored-by: Prakhar Shukla <[email protected]> Co-authored-by: Weishu Zhao <[email protected]> Co-authored-by: BhumikaMatharu <[email protected]> Co-authored-by: Bhumika Kaur Matharu <[email protected]> Co-authored-by: am-lim <[email protected]>

… check (Azure#28398)

…uckets (Azure#28378) Co-authored-by: NoriZC <[email protected]>

azure-client-tools-bot-prd · 2025-09-15T23:22:01Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Pull Request Overview

This PR makes the source list parameter optional for the redistribute throughput API in CosmosDB. Previously, the API would throw an error when the source list was null or not passed, but now it supports empty source lists to provide more flexibility.

Key Changes

Updated the redistribute throughput API to handle optional source lists
Modified validation logic to accept empty/null source lists instead of throwing errors

Reviewed Changes

Copilot reviewed 2 out of 526 changed files in this pull request and generated 1 comment.

File	Description
src/CosmosDB/CosmosDB.Management.Sdk/CosmosDB.Management.Sdk.csproj	Added BOM character to project file
NuGet.Config	Added empty lines to configuration file

Copilot · 2025-09-15T23:22:17Z

src/CosmosDB/CosmosDB.Management.Sdk/CosmosDB.Management.Sdk.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">


The addition of a UTF-8 BOM (Byte Order Mark) character at the beginning of the project file is unnecessary and can cause issues with some tools and editors. Project files should be saved as UTF-8 without BOM.

Suggested change

<Project Sdk="Microsoft.NET.Sdk">

<Project Sdk="Microsoft.NET.Sdk">

isra-fel · 2025-09-15T23:31:08Z

/azp run

azure-pipelines · 2025-09-15T23:31:14Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

VeryEarly · 2025-09-16T09:35:11Z

NuGet.Config

+

please remove this change from your PR

VeryEarly

please remove changes under azure-powershell/generated from your PR

VeryEarly · 2025-09-16T09:36:47Z

src/CosmosDB/CosmosDB.Management.Sdk/CosmosDB.Management.Sdk.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">


what is this change for?

VeryEarly · 2025-09-16T09:37:27Z

src/CosmosDB/CosmosDB.Management.Sdk/README.md

-commit: 2afa5b356adf6cf51209d2cf28d38644c69d9832
-apiversion: "2024-11-15"
-previewapiversion: "2024-12-01-preview"
+commit: main


please use a specific commit id instead of main

VeryEarly · 2025-09-16T09:41:23Z

src/CosmosDB/CosmosDB/ChangeLog.md

@@ -19,6 +19,14 @@
 -->

 ## Upcoming Release
+* Update Redistribute Throughput API to support source list as optional.


it looks like your base branch was based on the preview feature branch, and incorrectly targeting to main branch, please double check your target release

github-actions · 2025-09-16T09:42:41Z

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

isra-fel · 2025-10-20T03:23:15Z

Kindly ping @lnajaroen

isra-fel · 2025-10-27T05:52:31Z

Closing the PR for lack of activity. Feel free to reopen to continue working on it. Thanks 😀

carjackson-msft and others added 30 commits February 25, 2024 22:27

Merge main changes into Az.CosmosDB-preview-2024 (Azure#24252)

a7354be

* cherry-pick stable change into preview; stable:Azure#24199 * 1 out of 7 fixed * fixing other 2 tests * fixing remaining 4 tests failure due to session record

fix naming convention SDK

0ac59a7

merging preview branch in

d2a5eff

merging preview branch in

7be4e47

regenerate sdk

14ea6c6

re-record tests

6e5537a

fix changelog

4c68349

nit spacing

75b80e2

Merge pull request Azure#26066 from carjackson-msft/Az.CosmosDB-preview

d5a3583

[DoNotSquash] Get Az.CosmosDB-preview branch up to date

Merge with master; Using 2024-05-15-preview version

ef1f66a

Synced with Az.CosmosDB-preview

080cba6

Removed reference to ScenarioTest.ResourceManager

82bb655

Merge remote-tracking branch 'pjohari/main' into azure_preview

a3315cb

Update Start-AzNetAppFilesPeerExternalCluster.md

f156dc3

Test recordings

28d2a7e

Merge branch 'azure_preview' of https://github.com/pjohari-ms/azure-p…

a985158

…owershell into azure_preview

Merge with master

40ec42f

Recordings

1d9a150

Merge remote-tracking branch 'Azure/legacy-main-tools-2025-02-14' int…

0a883fd

…o azure_preview

Merge remote-tracking branch 'Azure/main' into azure_preview

3aad17d

Merge pull request Azure#27171 from VeryEarly/yabo/pjohari-ms/azure_p…

b23ea72

…review [CosmosDB] Sync main to CosmosDB preview

Merge pull request Azure#27176 from Azure/yabo/sync-CosmosDB

0ff9167

[CosmosDB] Sync main to CosmosDB preview

Merge remote-tracking branch 'azure/main' into Az.CosmosDB-preview

c0c9be9

Generated 20250501preview models

c577355

first push

817bb03

Fixed the build error

0e4394d

fixed the tests and uploaded test results

23f5317

Test changes

bf9aaf8

YanaXu and others added 12 commits July 9, 2025 16:22

[CosmosDB] Bug fix for Datetime.ToString() (Azure#28156)

d8e89d5

CosmosDB OOB Release (Azure#28160)

ab683f7

PS cosmos db restore command: Skipping client side restore validation…

9496aa0

… check (Azure#28398)

Fix SQL container throughput update to preserve existing throughput b…

e6a4fab

…uckets (Azure#28378) Co-authored-by: NoriZC <[email protected]>

Merge branch 'main' into Az.CosmosDB-preview

1b779a6

sync cosmosdb (Azure#28433)

85ec06b

[skip ci] Archive 85ec06b (Azure#28434)

cc86845

Rerecord tests (Azure#28444)

fb94d19

Update module version to 2.0.7 (Azure#28459)

30ffa59

CosmosDB OOB Release (Azure#28454)

3a29d06

make source list optional for redistribute throughput API

6477e62

Copilot AI review requested due to automatic review settings September 15, 2025 23:21

Copilot AI reviewed Sep 15, 2025

View reviewed changes

update changelog

018a96e

VeryEarly self-assigned this Sep 16, 2025

VeryEarly reviewed Sep 16, 2025

View reviewed changes

NuGet.Config

Copy link

Collaborator

VeryEarly Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this change from your PR

VeryEarly requested changes Sep 16, 2025

View reviewed changes

VeryEarly reviewed Sep 16, 2025

View reviewed changes

VeryEarly added the Do Not Merge 🚫 label Sep 16, 2025

github-actions bot mentioned this pull request Oct 1, 2025

Monthly issue metrics report #28630

Closed

isra-fel closed this Oct 27, 2025

		@@ -1,4 +1,4 @@
		<Project Sdk="Microsoft.NET.Sdk">
		<Project Sdk="Microsoft.NET.Sdk">

make source list optional for redistribute throughput API #28561

make source list optional for redistribute throughput API #28561

Uh oh!

Conversation

lnajaroen commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Sep 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

isra-fel commented Sep 15, 2025

Uh oh!

azure-pipelines bot commented Sep 15, 2025

Uh oh!

VeryEarly Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

VeryEarly left a comment

Choose a reason for hiding this comment

Uh oh!

VeryEarly Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

VeryEarly Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

VeryEarly Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

isra-fel commented Oct 20, 2025

Uh oh!

isra-fel commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

lnajaroen commented Sep 15, 2025 •

edited

Loading