-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[PS] RedisEnterpriseCache add breaking change for migration autorest v4 #28621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds breaking change notifications to the RedisEnterpriseCache module as part of migrating to AutoRest v4. The changes prepare users for upcoming breaking changes in Az v15.0.0 by adding preview messages to affected cmdlets.
- Updates the ChangeLog with a preannounced breaking changes notice
- Adds breaking change preview messages to key cmdlets (Get, New, Update operations)
- Updates module dependencies and version information to support the migration
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ChangeLog.md | Added breaking changes preannouncement notice |
| Az.RedisEnterpriseCache.psd1 | Updated Az.Accounts dependency version and generation date |
| RedisEnterpriseCache.sln | Updated project GUID references |
| generate-info.json | Updated generation ID for AutoRest |
| docs/Az.RedisEnterpriseCache.md | Updated module GUID |
| custom/*.ps1 | Added PreviewMessage attributes to Get/New/Update cmdlets |
| README.md | Added AutoRest directives for breaking change messages |
| AssemblyInfo.cs | Updated assembly version from 1.4.1 to 1.5.0 |
| [Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Runtime.PreviewMessage("**********************************************************************************************`n | ||
| * This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *`n | ||
| * At least one change applies to this cmdlet. *`n | ||
| * See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n | ||
| ***************************************************************************************************")] |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The breaking change message is duplicated across multiple cmdlets. Consider defining this as a constant to improve maintainability and ensure consistency across all cmdlets.
src/RedisEnterpriseCache/RedisEnterpriseCache.Autorest/README.md
Outdated
Show resolved
Hide resolved
src/RedisEnterpriseCache/RedisEnterpriseCache.Autorest/README.md
Outdated
Show resolved
Hide resolved
|
|
|
Contains preannoucement but passed the az 15 train. Will reconsider the timeline |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.