[Az.DataProtection] ADLS backup #28737

IannGeorges · 2025-10-24T03:51:38Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

…(20250701)

azure-client-tools-bot-prd · 2025-10-24T03:51:41Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

isra-fel · 2025-10-24T04:08:21Z

/azp run

azure-pipelines · 2025-10-24T04:08:38Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull Request Overview

This PR adds support for ADLS (Azure Data Lake Storage) backup in the DataProtection module. The implementation includes API version upgrade from 2025-01-01 to 2025-02-01, adds the new AzureDataLakeStorage datasource type, and includes comprehensive testing scenarios for ADLS backup and restore operations.

Key Changes:

API version upgrade from Api202501 to Api20250201 across documentation
Addition of AzureDataLakeStorage as a supported datasource type
New ADLS-specific test scenarios and test configuration
Documentation corrections (spelling fixes)

Reviewed Changes

Copilot reviewed 140 out of 150 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`help/*.md`	Updated API model references from Api202501 to Api20250201
`docs/*.md`	Updated API model references and corrected documentation text
`Az.DataProtection.psd1`	Updated module generation date and Az.Accounts version requirement
`DataProtection.sln`	Updated project GUID reference
`test/utils.ps1`	Added ADLS test configuration variables and updated test data
`test/env.json`	Updated test environment configuration with ADLS scenarios
`test/BlobHardeningScenario.Tests.ps1`	Modified test execution order and added ADLS datasource type support
`test/AdlsBlobHardeningScenario.Tests.ps1`	New test file for ADLS backup scenarios
`test/*.Tests.ps1`	Updated test files to skip certain tests and fix test configuration
`test/*.Recording.json`	Updated test recordings with new API version
`generate-info.json`	Updated generation ID

Comments suppressed due to low confidence (1)

src/DataProtection/DataProtection/Az.DataProtection.psd1:1

The required Az.Accounts version has been changed from 4.2.0 to 5.3.0. Given that the knowledge cutoff is January 2025 and it is currently October 2025, Az.Accounts version 5.3.0 may be a future version. Please verify that Az.Accounts version 5.3.0 actually exists and is available.

src/DataProtection/DataProtection.Autorest/test/BlobHardeningScenario.Tests.ps1

isra-fel · 2025-10-26T15:38:12Z

/azp run

azure-pipelines · 2025-10-26T15:38:29Z

Azure Pipelines successfully started running 3 pipeline(s).

…with external modules

IannGeorges · 2025-10-26T23:14:57Z

@isra-fel could you please retrigger the pipeline?

isra-fel · 2025-10-26T23:38:23Z

/azp run

azure-pipelines · 2025-10-26T23:38:41Z

Azure Pipelines successfully started running 3 pipeline(s).

IannGeorges · 2025-10-27T00:14:19Z

@isra-fel could you please review PR?

isra-fel

Looks good but please update the changelog

github-actions · 2025-10-27T02:50:00Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

IannGeorges · 2025-10-27T03:36:51Z

@isra-fel updated changelog.md

IannGeorges · 2025-10-27T03:38:38Z

@hiaga could you please review PR?

isra-fel · 2025-10-27T03:39:26Z

/azp run

azure-pipelines · 2025-10-27T03:39:42Z

Azure Pipelines successfully started running 3 pipeline(s).

hiaga · 2025-10-27T12:56:27Z

src/DataProtection/DataProtection.Autorest/Properties/AssemblyInfo.cs

-[assembly: System.Reflection.AssemblyFileVersionAttribute("2.6.1")]
-[assembly: System.Reflection.AssemblyVersionAttribute("2.6.1")]
+[assembly: System.Reflection.AssemblyFileVersionAttribute("2.7.0")]
+[assembly: System.Reflection.AssemblyVersionAttribute("2.7.0")]


is this auto updated or we are updating manually ?

hiaga · 2025-10-27T12:58:33Z

src/DataProtection/DataProtection/Az.DataProtection.psd1


 # Type files (.ps1xml) to be loaded when importing this module
-# TypesToProcess = @()
+TypesToProcess = @()


why are we changing this ?

hiaga · 2025-10-27T12:58:52Z

src/DataProtection/DataProtection/Az.DataProtection.psd1


 # Script files (.ps1) that are run in the caller's environment prior to importing this module.
-# ScriptsToProcess = @()
+ScriptsToProcess = @()


same as below

hiaga · 2025-10-27T13:18:26Z

...stom/Cmdlets/Platform/BackupInstance/New-AzDataProtectionBackupConfigurationClientObject.ps1

+        if($DatasourceType.ToString() -eq "AzureDataLakeStorage"){
+            $dataSourceParam = [Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api20250201.AdlsBlobBackupDatasourceParameters]::new()
+            $dataSourceParam.ObjectType = "AdlsBlobBackupDatasourceParameters"
+


can we remove code duplication here ? the logic seems to be same as blob

hiaga · 2025-10-27T13:19:40Z

...on.Autorest/custom/Cmdlets/Platform/BackupInstance/Update-AzDataProtectionBackupInstance.ps1

+                elseif ($DatasourceType -eq "AzureDataLakeStorage"){
+                    $backupConfiguration = [Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api20250201.AdlsBlobBackupDatasourceParameters]::new()
+                    $backupConfiguration.ObjectType = "AdlsBlobBackupDatasourceParameters"
+                }


you can use this similar logic in configuration command to reduce code duplication

hiaga · 2025-10-27T13:25:07Z

...ction.Autorest/custom/Cmdlets/Platform/Restore/Initialize-AzDataProtectionRestoreRequest.ps1

+                        } 
+                        elseif( ($manifest.renameContainersEnabled -ne $true) -and ($hasRenameTo)){
+                            throw "DatasourceType $DatasourceType does not support renaming containers"
+                        }


do we also need validation around other parameter for ILR or this param can be given independently

hiaga · 2025-10-27T13:26:11Z

.../DataProtection.Autorest/custom/Cmdlets/Platform/Vault/Set-AzDataProtectionMSIPermission.ps1

        Write-Host "Using Vault UAMI with ARMId: $UserAssignedIdentityARMId with Principal ID: $vaultIdentity"
    } else {
-        $vaultIdentity = $vault.Identity.PrincipalId
+        $vaultIdentity = $vault.IdentityPrincipalId


why are we changing this ?

hiaga · 2025-10-27T13:42:44Z

src/DataProtection/DataProtection.Autorest/test/BlobHardeningScenario.Tests.ps1

-        $targetStorageAccount = Get-AzStorageAccount -ResourceGroupName $targetStorageAccountRGName -Name $targetStorageAccountName
-        $targetContainers = Get-AzStorageContainer -Context $targetStorageAccount.Context | Where-Object { $_.Name -match "^con" }
-        foreach($containerName in $targetContainers.Name){
-            Remove-AzStorageContainer -Context $targetStorageAccount.Context -Name $containerName -Confirm:$false -Force


why are we removing test code? we can skip this test instead ?

ianna1-admin added 6 commits October 21, 2025 20:48

update readme with swagger API version & commit ID

ad049c8

replace custom cmds with old api version (202501) to new api version …

c599d5f

…(20250701)

fix error discovered in unit test

c0df399

functional changes for adls & blob manifest & unit tests

90552da

adls test recording

3c2ea00

auto rest build generation changes

a00d285

Copilot AI review requested due to automatic review settings October 24, 2025 03:51

IannGeorges requested review from hiaga and removed request for Copilot October 24, 2025 03:51

IannGeorges added this to the Az 14.6.0 (11/04/2025) milestone Oct 24, 2025

data protection test recording & corresponding changes

66f445e

IannGeorges changed the title ~~[Az.DataProtection] ADLS backup + rename restore container~~ [Az.DataProtection] ADLS backup Oct 26, 2025

IannGeorges force-pushed the users/ianna/adlsbackup2510 branch from dc362d9 to 66f445e Compare October 26, 2025 15:28

Copilot AI review requested due to automatic review settings October 26, 2025 15:28

Copilot AI reviewed Oct 26, 2025

View reviewed changes

src/DataProtection/DataProtection.Autorest/test/BlobHardeningScenario.Tests.ps1 Show resolved Hide resolved

src/DataProtection/DataProtection.Autorest/test/BlobHardeningScenario.Tests.ps1 Outdated Show resolved Hide resolved

run tests only in live mode due to issues when running playback mode …

8ae3b6c

…with external modules

ianna1-admin added 2 commits October 26, 2025 18:25

Correct test param

d6ca8a6

Remove debug traces

76e04e9

IannGeorges requested a review from isra-fel October 27, 2025 00:18

isra-fel requested changes Oct 27, 2025

View reviewed changes

isra-fel assigned IannGeorges Oct 27, 2025

isra-fel added the needs-revision label Oct 27, 2025

Add ChangeLog.md

d19a4c2

hiaga reviewed Oct 27, 2025

View reviewed changes

Uh oh!

[Az.DataProtection] ADLS backup #28737

Are you sure you want to change the base?

[Az.DataProtection] ADLS backup #28737

Conversation

IannGeorges commented Oct 24, 2025

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Oct 24, 2025

Uh oh!

isra-fel commented Oct 24, 2025

Uh oh!

azure-pipelines bot commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

isra-fel commented Oct 26, 2025

Uh oh!

azure-pipelines bot commented Oct 26, 2025

Uh oh!

IannGeorges commented Oct 26, 2025

Uh oh!

isra-fel commented Oct 26, 2025

Uh oh!

azure-pipelines bot commented Oct 26, 2025

Uh oh!

IannGeorges commented Oct 27, 2025

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 27, 2025

Uh oh!

IannGeorges commented Oct 27, 2025

Uh oh!

IannGeorges commented Oct 27, 2025

Uh oh!

isra-fel commented Oct 27, 2025

Uh oh!

azure-pipelines bot commented Oct 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants