Skip to content

Sync eng/common directory with azure-sdk-tools for PR 12529 #6798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sync eng/common directory with azure-sdk-tools for PR 12529 #6798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions eng/common/scripts/stress-testing/find-all-stress-packages.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ function FindStressPackages(
$filters['stressTest'] = 'true'
$packages = @()
$chartFiles = Get-ChildItem -Recurse -Filter 'Chart.yaml' $directory
Write-Host "Found chart files:"
Write-Host ($chartFiles -join "`n")
if ($chartFiles) {
Write-Host "Found chart files:"
Write-Host ($chartFiles -join "`n")
}

if (!$MatrixFileName) {
$MatrixFileName = 'scenarios-matrix.yaml'
Expand Down
4 changes: 4 additions & 0 deletions eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ function DeployStressTests(
-MatrixFilters $MatrixFilters `
-MatrixReplace $MatrixReplace `
-MatrixNonSparseParameters $MatrixNonSparseParameters)
if (!$pkgs -or !$pkgs.Length) {
Write-Warning "No stress test packages found in $searchDirectory"
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message references an undefined variable $searchDirectory. Based on the function signature, this should be $SearchDirectory (capitalized). This will result in an incomplete error message that doesn't show the directory path where packages were searched.

Suggested change
Write-Warning "No stress test packages found in $searchDirectory"
Write-Warning "No stress test packages found in $SearchDirectory"

Copilot uses AI. Check for mistakes.
exit 0
}
Write-Host "" "Found $($pkgs.Length) stress test packages:"
Write-Host $pkgs.Directory ""
foreach ($pkg in $pkgs) {
Expand Down