Skip to content

Conversation

@ostojicb
Copy link
Member

@ostojicb ostojicb commented Jan 12, 2022

"Mi Hybrid Link" refers to these two APIs:

  • ServerTrustCertificates
  • DistributedAvailabilityGroups

This PR originally included generated files, but they were picked up and merged with another PR (#27036)

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ostojicb
Copy link
Member Author

Hi @fengzhou-msft, can you take a look?

@fengzhou-msft
Copy link
Member

I don't see updates in generated SDK code. Is it in another PR and already merged?

@ostojicb
Copy link
Member Author

ostojicb commented Mar 2, 2022

Is it in another PR and already merged?

You're right, looks like it got merged yesterday with this PR: #27036

Will rename this PR to reflect only the added tests

@ostojicb ostojicb changed the title [SQL] Generate SDK for Mi Hybrid Link [SQL] Add tests for Mi Hybrid Link Mar 2, 2022
@fengzhou-msft fengzhou-msft merged commit 4c63831 into Azure:main Mar 3, 2022
yanfa317 pushed a commit to yanfa317/azure-sdk-for-net that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants