Skip to content

Conversation

@atallanki
Copy link

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Azure/azure-rest-api-specs#24926

atallanki and others added 2 commits September 12, 2023 13:51
Bringing up the forked repo to azure main commits
Commit for SDK Update 1.1.7
azure-rest-api-specs : Azure/azure-rest-api-specs#24926
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Nov 6, 2023
@github-actions
Copy link

github-actions bot commented Nov 6, 2023

Thank you for your contribution @atallanki! We will review the pull request and get back to you soon.

Adding additional test calls as they were removed and this is causing a breaking change
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atallanki track1 mgmt sdks are deprecated. We should continue on the track 2 mgmt sdk.

FYI @ArthurMa1978

@atallanki
Copy link
Author

@archerzz we do not have any active development efforts planned on ASE service. We are doing this just to stay compliant. Do we still need to upgrade?

@archerzz
Copy link
Member

archerzz commented Nov 9, 2023

@archerzz we do not have any active development efforts planned on ASE service. We are doing this just to stay compliant. Do we still need to upgrade?

@atallanki It's already upgraded. See https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/databoxedge/Azure.ResourceManager.DataBoxEdge

You just need to update the track2 SDK according to the latest swagger.

@jsquire
Copy link
Member

jsquire commented Nov 13, 2023

@atallanki:

Our automation is identifying you as a community contributor. Please review the Azure SDK onboarding documentation and ensure that your GitHub organization membership and permissions are correct.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

@ArthurMa1978
Copy link
Member

@atallanki please upgrade the pr with Track 2 and remove Track 1 sdk

@ArthurMa1978 ArthurMa1978 added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-author-feedback Workflow: More information is needed from author to address the issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants