Sync eng/common directory with azure-sdk-tools for PR 12529 #53380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools PR 12529, adding validation and logging improvements to stress testing deployment scripts. The changes enhance error handling by checking for empty package lists and conditionally logging chart file discovery.
- Added validation to exit gracefully when no stress test packages are found
- Added conditional guard for logging chart files only when they exist
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 | Added validation check for empty package list with early exit |
| eng/common/scripts/stress-testing/find-all-stress-packages.ps1 | Added conditional guard around chart files logging |
| -MatrixNonSparseParameters $MatrixNonSparseParameters) | ||
| if (!$pkgs -or !$pkgs.Length) { | ||
| Write-Warning "No stress test packages found in $searchDirectory" | ||
| exit 0 |
There was a problem hiding this comment.
Using exit 0 directly terminates the entire PowerShell process, which may not be appropriate if this function is called from another script or module. Consider using return instead to exit only the function scope, or throw an error to let the caller decide how to handle this case.
Suggested change
| exit 0 | |
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12529 See eng/common workflow