Migrate Devtestlabs to generate from TypeSpec #53452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the DevTestLabs SDK to generate from TypeSpec by updating the autorest configuration. The primary change is updating the OpenAPI specification reference to a newer commit and adding extensive swagger transformation directives to handle property definitions and parameter descriptions.
Key Changes:
- Updated the OpenAPI specification reference to a newer commit (471eab6)
- Removed an unused rename mapping for
WindowsOSState - Added multiple swagger transformation directives to remove
additionalPropertiesfrom various definitions and standardize parameter descriptions
| $["description"] = "The name of the notification channel"; | ||
| } | ||
| if ($["description"] && $["description"].includes("LabVirtualMachine")) { | ||
| $["description"] = "The name of the virtual machine"; |
There was a problem hiding this comment.
Inconsistent spacing in description strings. This line correctly has no leading space, but lines 222-237 have extra leading spaces. All description strings should have consistent formatting without leading spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue work of #51337
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.