Skip to content

Conversation

@ArcturusZhang
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copilot AI review requested due to automatic review settings December 9, 2025 09:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new feature to generate schema files for provisioning libraries. The generator now outputs a schema.log file that documents the structure of Azure resources in a readable format. Additionally, KeyVault resources have been updated to use API version 2025-05-01 as the default.

  • Added command-line option --generate-schema to control schema file generation (defaults to true)
  • Implemented schema generation logic that creates hierarchical resource documentation
  • Updated KeyVault resource API versions from 2024-11-01 to 2025-05-01
  • Added base.DefineProvisionableProperties() calls to KeyVault resources following the established pattern

Reviewed changes

Copilot reviewed 4 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/provisioning/Generator/src/Program.cs Sets the ShouldGenerateSchema flag on specifications based on the command-line option
sdk/provisioning/Generator/src/GenerateOptions.cs Adds the GenerateSchema command-line option with a default value of true
sdk/provisioning/Generator/src/Model/Specification.cs Adds ShouldGenerateSchema property and invokes GenerateSchema() during the build process
sdk/provisioning/Generator/src/Model/Specification.Schema.cs Implements the schema generation logic with tree building, cyclic reference detection, and type formatting
sdk/provisioning/Azure.Provisioning.KeyVault/src/Generated/ManagedHsmPrivateEndpointConnection.cs Updates default API version to 2025-05-01 and adds base.DefineProvisionableProperties() call
sdk/provisioning/Azure.Provisioning.KeyVault/src/Generated/ManagedHsm.cs Updates default API version to 2025-05-01 and adds base.DefineProvisionableProperties() call
sdk/provisioning/Azure.Provisioning.KeyVault/src/Generated/KeyVaultService.cs Updates default API version to 2025-05-01 and adds base.DefineProvisionableProperties() call
sdk/provisioning/Azure.Provisioning.KeyVault/src/Generated/KeyVaultSecret.cs Updates default API version to 2025-05-01 and adds base.DefineProvisionableProperties() call
sdk/provisioning/Azure.Provisioning.KeyVault/src/Generated/KeyVaultPrivateEndpointConnection.cs Updates default API version to 2025-05-01 and adds base.DefineProvisionableProperties() call

@ArcturusZhang ArcturusZhang merged commit 30fa6a7 into Azure:main Dec 11, 2025
11 checks passed
@ArcturusZhang ArcturusZhang deleted the generate-schema branch December 11, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants