Update Azure.ResourceManager.Carbon project to use the new MPG #54407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Azure.ResourceManager.CarbonOptimization SDK to use the new Management Plane Generator (MPG). The changes are entirely code generation updates resulting from switching the emitter package reference in the tsp-location.yaml file.
Key changes:
- Updated the emitter package path from legacy to the new azure-typespec-http-client-csharp-mgmt-emitter
- Updated the TypeSpec commit reference
- Regenerated all SDK code with the new generator, producing consistent patterns across models and serialization code
Reviewed changes
Copilot reviewed 16 out of 93 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Updated emitter package path to new MPG and updated commit reference |
| CarbonServiceRestOperations.cs | Refactored to CarbonService class with new structure and RequestContext pattern |
| ProviderConstants.cs | Added partial modifier and XML documentation |
| UnknownCarbonEmissionQueryFilter.cs | Updated constructor patterns and field naming conventions |
| UnknownCarbonEmissionQueryFilter.Serialization.cs | Updated serialization implementation with new patterns |
| UnknownCarbonEmission.cs | Updated constructor patterns and field naming |
| UnknownCarbonEmission.Serialization.cs | Updated serialization methods and patterns |
| TopItemsSummaryReportQueryFilter.cs | Removed public constructor, updated internal constructor |
| TopItemsSummaryReportQueryFilter.Serialization.cs | Updated serialization with new deserialization patterns |
| TopItemsMonthlySummaryReportQueryFilter.cs | Removed public constructor, updated internal constructor |
| TopItemsMonthlySummaryReportQueryFilter.Serialization.cs | Updated serialization with new patterns |
| SubscriptionAccessDecision.cs | Updated field naming and access modifiers |
| SubscriptionAccessDecision.Serialization.cs | Updated serialization methods |
| Multiple Resource* model files | Updated constructors and field naming across all resource models |
| Multiple Item* and Carbon* model files | Consistent updates to match new generator patterns |
| CarbonEmissionScope.cs | Added XML documentation and nullable implicit operator |
| CarbonEmissionQuerySortDirection.cs | Added XML documentation and nullable implicit operator |
| CarbonEmissionQueryReportType.cs | Added XML documentation and nullable implicit operator |
| CarbonEmissionQueryOrderByColumn.cs | Added XML documentation and nullable implicit operator |
| CarbonEmissionQueryFilter.cs | Made class abstract, updated constructors and field naming |
| CarbonEmissionQueryFilter.Serialization.cs | Added serialization helper methods and updated patterns |
| CarbonEmissionQueryDateRange.cs | Updated field naming and removed deserialization constructor |
| CarbonEmissionQueryDateRange.Serialization.cs | Updated serialization methods |
| CarbonEmissionOverallSummary.cs | Updated constructor patterns |
| CarbonEmissionMonthlySummary.cs | Updated constructor patterns and field naming |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Member
|
should we remove autorest.csharp dependency? |
Member
Author
|
/check-enforcer override |
live1206
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53867
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.