Skip to content

Conversation

@haiyuazhang
Copy link
Member

@haiyuazhang haiyuazhang commented Dec 10, 2025

This PR address the issue PrivateEndpointConnection resource is not generated when migrating service storagesync to new management plain generator

Copilot AI review requested due to automatic review settings December 10, 2025 06:37
@haiyuazhang haiyuazhang marked this pull request as draft December 10, 2025 06:37
@github-actions github-actions bot added CodeGen Issues that relate to code generation Mgmt This issue is related to a management package. labels Dec 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for a new built-in resource operation decorator and the @armResourceWithParameter decorator to the Azure Management Generator. These additions enable better handling of resource operations with parameters and built-in operation templates.

  • Introduces builtInResourceOperationName decorator for handling built-in resource operations
  • Adds armResourceWithParameter decorator support for resources with parameters
  • Updates resource model detection to include the new decorator
  • Adds test case demonstrating usage with PrivateEndpoints template

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
eng/packages/http-client-csharp-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/PrivateEndpointConnection.tsp Adds test case for new PrivateEndpoints resource template with StorageSyncService, removes unused TypeSpec.Rest import
eng/packages/http-client-csharp-mgmt/emitter/src/sdk-context-options.ts Defines constants for builtInResourceOperation and armResourceWithParameter decorators, adds armResourceWithParameterRegex to additionalDecorators
eng/packages/http-client-csharp-mgmt/emitter/src/resource-detection.ts Implements parseResourceOperation handling for builtInResourceOperationName decorator, updates getAllResourceModels to detect armResourceWithParameter decorated models

@haiyuazhang haiyuazhang force-pushed the haiyzhan/support_new_resource_decorator branch from eab1782 to ef8f9ee Compare December 11, 2025 07:11
@haiyuazhang haiyuazhang changed the title Support new resource decorator Support new resource decorator armResourceWithParameter Dec 11, 2025
@haiyuazhang haiyuazhang marked this pull request as ready for review December 11, 2025 07:15
@haiyuazhang haiyuazhang merged commit d779a56 into Azure:main Dec 11, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CodeGen Issues that relate to code generation Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants