[Attestation] SDK validation for TypeSpec #54423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Azure.ResourceManager.Attestation SDK to validate against TypeSpec definitions, transitioning from API version 2021-06-01-preview to the stable 2021-06-01 version. The changes include model renames for better clarity, new authentication type support for TPM attestation, improved API structure with proper property exposure, and pagination support enhancements.
Key Changes:
- Upgraded API version from preview (
2021-06-01-preview) to stable (2021-06-01) - Renamed models for clarity:
JsonWebKey→AttestationPolicyJsonWebKey,PublicNetworkAccessType→AttestationProviderPublicNetworkAccessType - Added new
TpmAttestationAuthenticationTypeenum and support in creation/patch operations - Made
AttestationServicePatchSpecificParamspublic and properly exposed asPropertiesonAttestationProviderPatch - Renamed operations:
GetAttestationProvidersByDefaultProvider→GetDefaultAttestationProviders,GetDefaultByLocationAttestationProvider→GetDefaultAttestationProviderByLocation - Added pagination support for private endpoint connection listing
Reviewed changes
Copilot reviewed 7 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| autorest.md | Updated spec reference and added model rename mappings and operation name overrides |
| TpmAttestationAuthenticationType.cs | New enum type for TPM attestation authentication settings |
| PublicNetworkAccessType.cs | Removed (replaced by AttestationProviderPublicNetworkAccessType) |
| AttestationProviderPublicNetworkAccessType.cs | New enum type replacing PublicNetworkAccessType |
| AttestationPolicyJsonWebKey.cs | Renamed from JsonWebKey for better clarity |
| AttestationServicePatchSpecificParams.cs | Changed from internal to public, added TpmAttestationAuthentication property |
| AttestationServiceCreationSpecificParams.cs | Added TpmAttestationAuthentication property, updated to use renamed types |
| AttestationProviderPatch.cs | Exposed Properties directly instead of flattened property |
| AttestationProviderData.cs | Added TpmAttestationAuthentication property, updated type references |
| AttestationPrivateLinkResourceListResult.cs | Updated constructor, added NextLink property for pagination |
| AttestationPrivateEndpointConnectionListResult.cs | Updated constructor, added NextLink property for pagination |
| PrivateEndpointConnectionsRestOperations.cs | Added NextPage methods for pagination support |
| AttestationProvidersRestOperations.cs | Reordered methods (no functional changes to existing operations) |
| Extension files | Updated method names per operation overrides |
| Test files | Updated to use new type names and proper property structure |
| API files | Updated public API surface to reflect all changes |
...ttestation/Azure.ResourceManager.Attestation/api/Azure.ResourceManager.Attestation.net8.0.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSP PR: Azure/azure-rest-api-specs#37548
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.