Skip to content

Conversation

@heaths
Copy link
Member

@heaths heaths commented Oct 26, 2025

No description provided.

@heaths heaths requested a review from LarryOsterman as a code owner October 26, 2025 07:11
Copilot AI review requested due to automatic review settings October 26, 2025 07:11
@heaths heaths requested a review from RickWinter as a code owner October 26, 2025 07:11
@heaths heaths requested a review from LarryOsterman October 26, 2025 07:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Rust guidelines to provide clearer guidance on handling crate-specific errors in Azure SDK libraries. The changes clarify that crates can return or convert errors into azure_core::Result<T>, and add a new section detailing when and how to implement crate-specific error types.

Key Changes:

  • Modified the core error requirement to allow conversion into azure_core::Result<T>
  • Added comprehensive guidelines for implementing crate-specific error types when domain-specific information must be exposed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@heaths
Copy link
Member Author

heaths commented Oct 27, 2025

@weshaggard can you override? A Go aka.ms link is broken and someone just needs to fix it (I hear someone is aware already), but should not hold up other languages.

@heaths
Copy link
Member Author

heaths commented Oct 27, 2025

@gracewilcox made a new link, the but the old link needs to be fixed. I grepped for it and there are dozens if not hundreds of locations. @weshaggard please override. She sent a message to the owner to fix the old one. Hypothetically, aka links should never be broken for more than a short time - we shouldn't replace them, or at least point old vanity ones at new vanity ones.

@heaths
Copy link
Member Author

heaths commented Oct 27, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member

I fixed the go aka links earlier today.

@weshaggard weshaggard merged commit d019037 into Azure:main Oct 27, 2025
11 of 12 checks passed
@heaths heaths deleted the rust-errors branch October 27, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants