[pyamqp] pylint/mypy/black #314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swathipil
approved these changes
Mar 16, 2022
Member
swathipil
left a comment
swathipil
left a comment
There was a problem hiding this comment.
left a few comments but o/w lgtm!
| Any, | ||
| Union, | ||
| Optional, | ||
| ) # pylint: disable=unused-import |
Member
There was a problem hiding this comment.
intentional disable unused-import or is this leftover from before?
|
|
||
| def encode_float( | ||
| output, value, with_constructor=True, **kwargs | ||
| ): # pylint: disable=unused-argument |
Member
There was a problem hiding this comment.
I'm assuming all the unused-arguments are because of TODOs and they'll be used in the future?
| size = struct.unpack(">I", size)[0] | ||
| offset = frame_header[4] | ||
| frame_type = frame_header[5] | ||
| # frame_type = frame_header[5] |
Member
There was a problem hiding this comment.
is this a TODO/commented for now or should it be deleted?
| size = struct.unpack(">I", size)[0] | ||
| offset = frame_header[4] | ||
| frame_type = frame_header[5] | ||
| # frame_type = frame_header[5] |
| return (int(utc_now().timestamp()) - token_put_time) >= auth_timeout | ||
| else: | ||
| return False | ||
| return 0 < auth_timeout <= (int(utc_now().timestamp()) - token_put_time) |
Member
There was a problem hiding this comment.
😮 Is this Python 3 syntax? Was this always available?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing issue: Azure/azure-sdk-for-python#22455