Skip to content

Conversation

@tobiasehlert
Copy link
Contributor

Overview/Summary

This pull request includes changes to add Private DNS zone and Private DNS zone Virtual Network Link for Azure Managed Prometheus by the connectivity-module. The most important changes include updates to the README.md, modules/connectivity/README.md, modules/connectivity/locals.tf, modules/connectivity/variables.tf, and variables.tf files.

Add support for Private DNS zone and Private DNS zone Virtual Network Link for Managed Prometheus:

This PR fixes/adds/changes/removes

N/A

Breaking Changes

N/A

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Terraform will perform the following actions:

  # module.enterprise_scale.azurerm_private_dns_zone.connectivity["/subscriptions/<subscription-id>/resourceGroups/myalz-connectivity-swedencentral/providers/Microsoft.Network/privateDnsZones/privatelink.swedencentral.prometheus.monitor.azure.com"] will be created
  + resource "azurerm_private_dns_zone" "connectivity" {
      + id                                                    = (known after apply)
      + max_number_of_record_sets                             = (known after apply)
      + max_number_of_virtual_network_links                   = (known after apply)
      + max_number_of_virtual_network_links_with_registration = (known after apply)
      + name                                                  = "privatelink.swedencentral.prometheus.monitor.azure.com"
      + number_of_record_sets                                 = (known after apply)
      + resource_group_name                                   = "myalz-connectivity-swedencentral"
      + tags                                                  = {
          + "deployedBy" = "terraform/azure/caf-enterprise-scale"
        }

      + soa_record (known after apply)

      + timeouts {}
    }

  # module.enterprise_scale.azurerm_private_dns_zone_virtual_network_link.connectivity["/subscriptions/<subscription-id>/resourceGroups/myalz-connectivity-swedencentral/providers/Microsoft.Network/privateDnsZones/privatelink.swedencentral.prometheus.monitor.azure.com/virtualNetworkLinks/<subscription-id>-<random-id>"] will be created
  + resource "azurerm_private_dns_zone_virtual_network_link" "connectivity" {
      + id                    = (known after apply)
      + name                  = "<subscription-id>-<random-id>"
      + private_dns_zone_name = "privatelink.swedencentral.prometheus.monitor.azure.com"
      + registration_enabled  = false
      + resource_group_name   = "myalz-connectivity-swedencentral"
      + tags                  = {
          + "deployedBy" = "terraform/azure/caf-enterprise-scale"
        }
      + virtual_network_id    = "/subscriptions/<subscription-id>/resourceGroups/myalz-connectivity-swedencentral/providers/Microsoft.Network/virtualNetworks/myalz-hub-swedencentral"

      + timeouts {}
    }

Plan: 2 to add, 0 to change, 0 to destroy.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@tobiasehlert
Copy link
Contributor Author

@matt-FFFFFF, looks good so we can get it merged? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants