Skip to content

Make all Contentful fields optional and nullable #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weotch merged 2 commits into from
Sep 10, 2025
Merged

Make all Contentful fields optional and nullable #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
873bc02
Make all Contentful fields optional and nullable
weotch Sep 10, 2025
b3e2905
Explicitly check for null
weotch Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/contentful/src/lib/aspectRatio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const orientationMediaQueries = [
export function getImageAspect(
image: ContentfulImageAsset | undefined | null,
): number | undefined {
if (!image) return undefined;
if (!image || image.width == null || image.height == null) return undefined;
return image.width / image.height;
}

Expand Down
12 changes: 6 additions & 6 deletions packages/contentful/src/types/contentfulVisualTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,25 @@ export type ContentfulVisualProps = {
image?: ContentfulImageAsset | null;
video?: ContentfulAsset | null;
src?: ContentfulVisualEntry | null;
alt?: string; // Can be inferrerd
alt?: string | null; // Can be inferrerd
} & Omit<ReactVisualProps, "alt" | "image" | "video">;

export type ContentfulImageAsset = ContentfulAsset & {
width: number;
height: number;
width?: number | null;
height?: number | null;
};

export type ContentfulAsset = {
title?: string | null;
description?: string; // Was not nullable in my tests
description?: string | null;
fileName?: string;
url: string;
url?: string | null;
};

export type ContentfulVisualEntry = {
image?: ContentfulImageAsset | null;
portraitImage?: ContentfulImageAsset | null;
video?: ContentfulAsset | null;
portraitVideo?: ContentfulAsset | null;
alt: string | null;
alt?: string | null;
};