Skip to content

Conversation

@bghgary
Copy link
Contributor

@bghgary bghgary commented Nov 12, 2025

No description provided.

@bghgary bghgary changed the title Fix build issues Build fixes Nov 12, 2025
@bghgary bghgary requested a review from Copilot November 13, 2025 00:05
@bghgary bghgary marked this pull request as ready for review November 13, 2025 00:05
Copilot finished reviewing on behalf of bghgary November 13, 2025 00:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses build-related issues across C++, CMake configuration, and npm dependencies.

  • Migrates C math functions to C++ standard library equivalents in Gradient.cpp
  • Reorganizes bgfx CMake configuration to use proper build options instead of compile definitions
  • Updates npm package-lock.json with peer dependency annotations

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
Polyfills/Canvas/Source/Gradient.cpp Replaces C math functions (fmax, fmin, sqrtf) with C++ standard library equivalents (std::max, std::min, std::sqrt) and adds <cmath> include
Dependencies/CMakeLists.txt Reorganizes bgfx configuration by converting BGFX_CONFIG_MULTITHREADED and BGFX_CONFIG_DEBUG_ANNOTATION from compile definitions to CMake options, and moves BGFX_GL_CONFIG_BLIT_EMULATION to OpenGL-specific section
Apps/package-lock.json Adds "peer": true annotations to various dependencies as per npm's peer dependency management
Files not reviewed (1)
  • Apps/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <[email protected]>
@bghgary bghgary merged commit 100af5f into BabylonJS:master Nov 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants