All themes cleaned up #2360
Merged
All themes cleaned up #2360
+486
−457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate local variable declarations from command substitution assignments to avoid masking return values, per shellcheck SC2155. Modified files: - themes/mbriggs/mbriggs.theme.bash (2 fixes) - themes/powerline-plain/powerline-plain.base.bash (1 fix) - themes/sirup/sirup.theme.bash (2 fixes) - themes/slick/slick.theme.bash (2 fixes) - themes/zork/zork.theme.bash (2 fixes) Total: 9 SC2155 violations fixed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Add double quotes around variable expansions to prevent globbing and word splitting, per shellcheck SC2086. Modified files: - themes/nwinkler_random_colors/nwinkler_random_colors.theme.bash (3 fixes) - themes/powerline-plain/powerline-plain.base.bash (4 fixes) - themes/powerturk/powerturk.theme.bash (5 fixes) - themes/ramses/ramses.theme.bash (2 fixes) - themes/sirup/sirup.theme.bash (2 fixes) - themes/slick/slick.theme.bash (2 fixes) - themes/zork/zork.theme.bash (2 fixes) Total: 19 SC2086 violations fixed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
akinomyoga
reviewed
Oct 15, 2025
themes/nwinkler_random_colors/nwinkler_random_colors.theme.bash
Outdated
Show resolved
Hide resolved
Co-authored-by: Koichi Murase <[email protected]>
Co-authored-by: Koichi Murase <[email protected]>
Co-authored-by: Koichi Murase <[email protected]>
akinomyoga
reviewed
Oct 16, 2025
akinomyoga
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
?to color variable expansionsTest plan
🤖 Generated with Claude Code