fix: handle expired auth gracefully and preserve credentials on upgrade #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes BenjaminOddou#13 This PR addresses issues with authentication handling: 1. **Silent auth failure**: When `get_plex_account()` returns `None` due to expired/invalid tokens, the workflow would crash with `'NoneType' object has no attribute 'watchlist'`. Now it gracefully degrades - search results are still shown but watchlist features are disabled until re-authentication. 2. **Version upgrade wipes credentials**: The version check in `utils.py` would delete ALL files including `accounts.json` and `servers.json` when the workflow version changes. This forced users to re-authenticate after every update. Now authentication files are preserved. Additionally, the version check now only runs when the Alfred environment variable is set, preventing accidental cleanup when running scripts from terminal for debugging. 3. **Auth failure logging**: Added logging when authentication fails in `accounts_add_delete.py` to help with debugging. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13
This PR addresses several authentication handling issues:
Silent auth failure: When
get_plex_account()returnsNonedue to expired/invalid tokens, the workflow would crash with'NoneType' object has no attribute 'watchlist'. Now it gracefully degrades - search results are still shown but watchlist features are disabled until re-authentication.Version upgrade wipes credentials: The version check in
utils.pywould delete ALL files includingaccounts.jsonandservers.jsonwhen the workflow version changes. This forced users to re-authenticate after every update. Now authentication files are preserved.Terminal debugging safety: The version check now only runs when the Alfred environment variable is set, preventing accidental cleanup when running scripts from terminal for debugging.
Auth failure logging: Added logging when authentication fails in
accounts_add_delete.pyto help with debugging.Test plan
🤖 Generated with Claude Code