Use C++17 [[fallthrough]] to make intentional fallthroughs explicit#405
Open
akien-mga wants to merge 1 commit intoBinomialLLC:masterfrom
Open
Use C++17 [[fallthrough]] to make intentional fallthroughs explicit#405akien-mga wants to merge 1 commit intoBinomialLLC:masterfrom
[[fallthrough]] to make intentional fallthroughs explicit#405akien-mga wants to merge 1 commit intoBinomialLLC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small cleanup that removes the need for a GCC-specific pragma.
Clang/Emscripten would also generate this warning BTW if
-Wimplicit-fallthroughwas passed explicitly (it doesn't seem to be enabled by-Wall -Wextra). From a quick test it can be silenced for both GCC and Clang-derived compilers by ignoring-Wimplicit-fallthroughinstead of-Wimplicit-fallthrough=(note the trailing=). But here using[[fallthrough]]is IMO better as it makes the intention explicit for all compilers.