Fix C++20 warning for deprecated enum operation#406
Open
Repiteo wants to merge 1 commit intoBinomialLLC:masterfrom
Open
Fix C++20 warning for deprecated enum operation#406Repiteo wants to merge 1 commit intoBinomialLLC:masterfrom
Repiteo wants to merge 1 commit intoBinomialLLC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup to circumvent repos targeting C++20 and above from having to suppress warnings over deprecated enum operations. The offending area was
X::num_rows + Y::num_rowsin the template declaration ofmatrix_combine_vertically, resulting in these warnings:deprecated-enum-enum-conversiondeprecated-anon-enum-enum-conversion5054(operator '*': deprecated between enumerations of different types)This was addressed by converting the offending file's anonymous enums to
static constexprvariables, which is the recommended way to declare scoped constants in C++17 and above.