Logo image added to all articles without an image #537
Conversation
|
Please explain your changes using the PR description template. |
|
@TimOsahenru instead of adding the image to each of the blog posts... Why not apply the image once in the template. This way if there is ever a change in the logo design we only need to change it in one place. |
kjaymiller
left a comment
kjaymiller
left a comment
There was a problem hiding this comment.
Check comments please
Gotcha! Thanks |
…hub.io into add-image-to-articles-without-images
|
@kjaymiller new changes have been committed. Please help review. Thanks |
| remote: https://rubygems.org/ | ||
| specs: | ||
| activesupport (7.2.1.1) | ||
| activesupport (7.1.4.1) |
There was a problem hiding this comment.
This seems like a regression. I would consider updating your gems.
| ffi (1.17.0-aarch64-linux-musl) | ||
| ffi (1.17.0-arm-linux-gnu) | ||
| ffi (1.17.0-arm-linux-musl) | ||
| ffi (1.17.0) |
There was a problem hiding this comment.
Not sure why all of these are removed. This could be an issue with our builds.
| jekyll-feed (~> 0.9) | ||
| jekyll-seo-tag (~> 2.1) | ||
| minitest (5.25.1) | ||
| mutex_m (0.2.0) |
There was a problem hiding this comment.
seems like things were added.
| arm64-darwin | ||
| x86-linux | ||
| x86-linux-gnu | ||
| x86-linux |
There was a problem hiding this comment.
duplicates that remove the gnu
| lang: en | ||
| title: "DjangoCon US 2023" | ||
| date: 2023-10-20 | ||
| featured_image: /assets/images/bpd_stacked.png |
There was a problem hiding this comment.
Do we want to remove these since it hardcodes the default image?
| lang: en | ||
| title: "Marlene Mhangami Recognized as Python Fellow for Q3 2023" | ||
| date: 2024-01-25 | ||
| featured_image: /assets/images/bpd_stacked.png |
There was a problem hiding this comment.
Do we want to remove these since it hardcodes the default image?
| lang: en | ||
| title: "Black Python Devs x PyCon US" | ||
| date: 2024-03-13 | ||
| featured_image: /assets/images/bpd_stacked.png |
There was a problem hiding this comment.
Do we want to remove these since it hardcodes the default image?
| author: Anotida Expected Msiiwa | ||
| lang: en | ||
| layout: post | ||
| featured_image: /assets/images/bpd_stacked.png |
There was a problem hiding this comment.
Do we want to remove these since it hardcodes the default image?
| date: 2024-08-15 | ||
| lang: en | ||
| author: Jay Miller | ||
| featured_image: /assets/images/bpd_stacked.png |
There was a problem hiding this comment.
Do we want to remove these since it hardcodes the default image?
| date: 2024-08-16 | ||
| author: Jay Miller | ||
| lang: en | ||
| featured_image: /assets/images/bpd_stacked.png |
There was a problem hiding this comment.
Do we want to remove these since it hardcodes the default image?
|
Reminder please update the PR Description |
|
Hello @kjaymiller I'm facing some challenges updating my |
2 participants
Issue Link 🔗:
Issue: #533
Type of Change
Description 📋
What: Provide an overview of the issue this PR addresses. Explain the context and background information.
Why: Describe why the changes are being made. Highlight key updates, new features, or bug fixes.
How: Explain how these changes will affect the project or end-users.
Checklist ✅
pre-commit run --allAdditional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.