Add importlib compatibility for newer versions of Python#109
Open
bijanagahi wants to merge 1 commit intoBlizzard:masterfrom
Open
Add importlib compatibility for newer versions of Python#109bijanagahi wants to merge 1 commit intoBlizzard:masterfrom
bijanagahi wants to merge 1 commit intoBlizzard:masterfrom
Conversation
In newer versions of python the imp module has been removed and replaced with importlib. Without changing too much of base behavior, this change allows users with newer versions of python to continue using heroprotocol.
Author
|
Alternatively, we can update the README to specify that python versions >=3.12 are no longer supported. |
Author
|
@Agilhardt not sure if you're still the primary for this repo. I know a few other devs still using this project and certain builds are now broken because of the new python updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In newer versions of python the
impmodule has been removed and replaced withimportlib. Without changing too much of base behavior, this change allows users with newer versions of python to continue using heroprotocol.