Added initial gps logger functionalities #57
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'm converting this PR to a draft for now, because significant work remains before it can be safely merged to the primary branch (that's used in production). Continue to develop in this branch for now, and we'll merge when there's a little more stability in the pull. |
| Serial.printf("DBG: After voltage monitoring start, free heap = %d B, delta = %d B\n", heap.CurrentSize(), heap.DeltaSinceLast()); | ||
|
|
||
| Serial.println("Starting GPS logger ..."); | ||
| GPSLogger = new gps::Logger(logManager); |
Collaborator
There was a problem hiding this comment.
We'll want this to be optional so that we don't have to turn it on if the hardware isn't there (or the user isn't interested). Similar code is used for IMU, etc.
| bool Logger::begin(void) | ||
| { | ||
| // Configure I2C pins for GPS | ||
| Wire.begin(33, 36); // SDA, SCL |
Collaborator
There was a problem hiding this comment.
Since this is also used by the IMU, we'll have to check that re-initialising this isn't going to cause problems (or vice versa if the IMU is also enabled).
added 5 commits
February 20, 2025 11:50
…sing, added I2C Bus properties to class constructor to allow for different clock speeds and increased buffer to accomodate the new variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial ZED RTK logger functionalities in GPSLogger cpp