Develop #327
Merged
Develop #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Item 엔티티 조회 시 N+1 개선
- LikeCount와 ScrapCount 조회 방식 개선
- 각각 조회에서 함께 조회로 개선
- 상태 데이터(likeStatus, scrapStatus, followStatus) 조회 변경
- 각각 조회에서 1개의 쿼리로 조회
선
- 추가로 발생하던 item_category와 celeb_category의 N+1 문제를 개선
- 아이템 상세조회 테스트 추가. - 비로그인 아이템 상세조회 테스트 추가. - 존재하지 않는 아이템 조회 시 예외 발생 테스트 추가.
- ItemService에 getItemDetail()과 관련된 테스트 추가.
- getCountDataByItemId() 관련 테스트 코드 추가. - getStatusDataByItemId() 관련 테스트 코드 추가.
Feature/refact item detail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입(하나 이상의 PR 타입을 선택해주세요)
반영 브랜치
변경 사항
테스트 결과