Eigen3 5.0.0 support #9112
Open
Eigen3 5.0.0 support #9112
+226
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soesau
changed the title
sloriot
reviewed
Oct 28, 2025
Shape_regularization/examples/Shape_regularization/CMakeLists.txt
Outdated
Show resolved
Hide resolved
Comment on lines
+17
to
+19
| find_package(Eigen3 QUIET) | ||
| include(CGAL_Eigen3_support) | ||
|
|
There was a problem hiding this comment.
Can't this find be included in the include file?
There was a problem hiding this comment.
Yes, you're right. That would make it shorter. However, for now, all those internal support files follow the same scheme of having the find_package outside..
There was a problem hiding this comment.
Consistency is a great thing so having all packages handled similar is the best, though I think that all packages should have the find inside so that maintenance will be easier as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adding support for Eigen3 5.0.0 by updating CMakeLists.txt scripts.
Release Management