Update to .NET 8, Add Seq.chunkBy #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@omaus can you review and release if it is fine? I need this in a downstream repo (BioFSharp) |
omaus
reviewed
Apr 22, 2025
Member
omaus
left a comment
omaus
left a comment
There was a problem hiding this comment.
Just a quick question about versioning, Seq.chunkBy seems absolutely plausible for me. 👍🏻
| <PackageReference Include="Fake.Api.Github" Version="6.0.0" /> | ||
| <PackageReference Include="Fake.Core.Process" Version="6.0.0" /> | ||
| <PackageReference Include="Fake.Core.ReleaseNotes" Version="6.0.0" /> | ||
| <PackageReference Include="Fake.Core.Target" Version="6.0.0" /> |
Member
There was a problem hiding this comment.
Just a quick question: Wasn't it the case that we wanted to keep all version tags exact? (I.e., Version="[6.0.0]")
Member
Author
There was a problem hiding this comment.
I think in the case of the build project it does not matter, but feel free to pin
Member
omaus
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.