Update redstone wire optimizations and fix #581 #583
Conversation
| private static boolean ignoreNonWires = false; | ||
|
|
||
| public static int getNeighborBlockSignal(Block wireBlock, RedstoneWireEvaluator evaluator, Level level, BlockPos pos) { | ||
| ignoreWires = true; |
There was a problem hiding this comment.
I am concerned about these static fields, mod compatibility with threading mods will definitely suffer
There was a problem hiding this comment.
I think converting them to a local variable should be possible if I am not misunderstanding the code
There was a problem hiding this comment.
yeah that'd work
2No2Name
left a comment
2No2Name
left a comment
There was a problem hiding this comment.
Since you are the original author of this optimization and also the tests are passing, I mostly trust that the code is correct. When merging I will change the static fields to local variables, as I do not see a good reason to keep them static.
| private static boolean ignoreNonWires = false; | ||
|
|
||
| public static int getNeighborBlockSignal(Block wireBlock, RedstoneWireEvaluator evaluator, Level level, BlockPos pos) { | ||
| ignoreWires = true; |
There was a problem hiding this comment.
I think converting them to a local variable should be possible if I am not misunderstanding the code
|
Rebased onto develop and replaced the static fields with local variables. Thanks for the PR |
2 participants
No description provided.