Skip to content

Adventure Mode dialogue cleanup #9237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2025
Merged

Adventure Mode dialogue cleanup #9237

merged 2 commits into from
Dec 4, 2025

Conversation

@aryst0krat
Copy link
Contributor

@aryst0krat aryst0krat commented Nov 24, 2025 •
edited
Loading

Purely non-functional changes

  • Unified language for action-based dialogue choices (such as changing "go away", "Walk Away", etc. to just "Leave")
  • Started unifying formatting for dialogue choices (removing periods from action-based dialogue choices, but haven't unified whether they use parentheses or not as I'm awaiting input for which to switch to)
  • Fixed punctuation and capitalization
  • Fixed some awkward or repetitive wording

@Hanmac Hanmac added the Adventure For the Adventure Module label Nov 24, 2025
@Hanmac Hanmac requested review from Simisays and dracontes and removed request for dracontes November 24, 2025 12:14
@Agetian Agetian self-requested a review December 4, 2025 09:26
@Agetian Agetian merged commit eb96461 into Card-Forge:master Dec 4, 2025
2 checks passed
@aryst0krat aryst0krat deleted the dialogue-cleanup branch December 4, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Agetian Agetian Agetian approved these changes

@Simisays Simisays Awaiting requested review from Simisays

@dracontes dracontes Awaiting requested review from dracontes

Assignees

No one assigned

Labels

Adventure For the Adventure Module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aryst0krat @Agetian @Hanmac