Skip to content

Fix: Make device connection text more generic #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanbox wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Make device connection text more generic #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/helpers/strings-de.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ let strings: { [key: string]: string } = {
"external-account-reconnect": "Erneut verbinden",
"external-account-refresh": "Aktualisieren",
"external-account-remove": "Entfernen",
"device-data-no-data": "Wenn Sie Apple Health, Google Fit, Fitbit oder Garmin verbunden haben, kommen Sie später zurück, um Ihre Daten anzuzeigen.",
"device-data-no-data": "Wenn Sie Ihr Gerät angeschlossen haben, kommen Sie später zurück, um Ihre Daten anzuzeigen.",
"no-notifications-received": "Keine Benachrichtigungen erhalten",
"next-button-text": "Weiter",
"lab-results-title": "Laborergebnisse",
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/strings-en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"external-account-reconnect": "Reconnect",
"external-account-refresh": "Refresh",
"external-account-remove": "Remove",
"device-data-no-data": "If you have connected Apple Health, Google Fit, Fitbit, or Garmin, check back later to view your data.",
"device-data-no-data": "If you have connected your device, check back later to view your data.",
"no-notifications-received": "No notifications received",
"next-button-text": "Next",
"lab-results-title": "Lab Results",
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/strings-es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"external-account-reconnect": "Volver a conectar",
"external-account-refresh": "Actualizar",
"external-account-remove": "Eliminar",
"device-data-no-data": "Si ha conectado Apple Health, Google Fit, Fitbit o Garmin, vuelva más tarde para ver sus datos.",
"device-data-no-data": "Si ha conectado tu dispositivo, vuelva más tarde para ver sus datos.",
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix pronoun agreement in Spanish translation.

The current translation mixes formal and informal pronouns ("ha conectado" with "tu"). For consistency, it should use either:

Informal style (preferred as the rest of the file uses informal "tu"):

-    "device-data-no-data": "Si ha conectado tu dispositivo, vuelva más tarde para ver sus datos.",
+    "device-data-no-data": "Si has conectado tu dispositivo, vuelve más tarde para ver tus datos.",

Or formal style:

-    "device-data-no-data": "Si ha conectado tu dispositivo, vuelva más tarde para ver sus datos.",
+    "device-data-no-data": "Si ha conectado su dispositivo, vuelva más tarde para ver sus datos.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"device-data-no-data": "Si ha conectado tu dispositivo, vuelva más tarde para ver sus datos.",
"device-data-no-data": "Si has conectado tu dispositivo, vuelve más tarde para ver tus datos.",

Copy link
Contributor

@bxh bxh Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to consult LLM on this one.

However, there’s a small inconsistency in the Spanish translation. The original version used a formal tone ("ha conectado") but the updated string switches to the informal possessive ("tu dispositivo"). You might want to adjust it to either use the formal possessive ("su dispositivo") or change the conjugation to match the informal register.

Copy link
Contributor

@coderabbitai coderabbitai bot Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bxh You're absolutely right! There's an inconsistency in the Spanish translation where formal and informal registers are mixed in the same sentence. The updated string uses "ha conectado" (formal) with "tu dispositivo" (informal).

To fix this, you can either:

  1. Use consistent formal register:
"device-data-no-data": "Si ha conectado su dispositivo, vuelva más tarde para ver sus datos.",
  1. Use consistent informal register:
"device-data-no-data": "Si has conectado tu dispositivo, vuelve más tarde para ver tus datos.",

The informal option (#2) tends to be more common in modern applications and creates a friendlier tone, but either option would resolve the inconsistency.

"no-notifications-received": "No se recibieron notificaciones.",
"next-button-text": "Siguiente",
"lab-results-title": "Resultados de laboratorio",
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/strings-fr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ let strings: { [key: string]: string } = {
"external-account-reconnect": "Reconnecter",
"external-account-refresh": "Actualiser",
"external-account-remove": "Supprimer",
"device-data-no-data": "Si vous avez connecté Apple Health, Google Fit, Fitbit ou Garmin, revenez plus tard pour consulter vos données.",
"device-data-no-data": "Si vous avez connecté votre appareil, revenez plus tard pour consulter vos données.",
"no-notifications-received": "Aucune notification reçue",
"next-button-text": "Suivant",
"lab-results-title": "Résultats de laboratoire",
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/strings-it.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ let strings: { [key: string]: string } = {
"external-account-reconnect": "Riconnetti",
"external-account-refresh": "Aggiorna",
"external-account-remove": "Rimuovi",
"device-data-no-data": "Se hai collegato Apple Health, Google Fit, Fitbit o Garmin, torna più tardi per visualizzare i tuoi dati.",
"device-data-no-data": "Se hai collegato il tuo dispositivo, torna più tardi per visualizzare i tuoi dati.",
"no-notifications-received": "Nessuna notifica ricevuta",
"next-button-text": "Avanti",
"lab-results-title": "Risultati di laboratorio",
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/strings-nl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ let strings: { [key: string]: string } = {
"external-account-reconnect": "Opnieuw verbinden",
"external-account-refresh": "Vernieuwen",
"external-account-remove": "Verwijderen",
"device-data-no-data": "Als u Apple Health, Google Fit, Fitbit of Garmin hebt aangesloten, kom dan later terug om uw gegevens te bekijken.",
"device-data-no-data": "Als u uw apparaat hebt aangesloten, kom dan later terug om uw gegevens te bekijken.",
"no-notifications-received": "Geen meldingen ontvangen",
"next-button-text": "Volgende",
"lab-results-title": "Laboratoriumresultaten",
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/strings-pl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ let strings: { [key: string]: string } = {
"external-account-reconnect": "Połącz ponownie",
"external-account-refresh": "Odśwież",
"external-account-remove": "Usuń",
"device-data-no-data": "Jeśli podłączyłeś Apple Health, Google Fit, Fitbit lub Garmin, wróć później, aby zobaczyć swoje dane.",
"device-data-no-data": "Jeśli podłączyłeś swoje urządzenie, wróć później, aby zobaczyć swoje dane.",
"no-notifications-received": "Nie otrzymano żadnych powiadomień",
"next-button-text": "Dalej",
"lab-results-title": "Wyniki badań laboratoryjnych",
Expand Down
2 changes: 1 addition & 1 deletion src/helpers/strings-pt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ let strings: { [key: string]: string } = {
"external-account-reconnect": "Reconectar",
"external-account-refresh": "Atualizar",
"external-account-remove": "Remover",
"device-data-no-data": "Se você conectou o Apple Health, Google Fit, Fitbit ou Garmin, volte mais tarde para ver seus dados.",
"device-data-no-data": "Se você conectou seu dispositivo, volte mais tarde para ver seus dados.",
"no-notifications-received": "Nenhuma notificação recebida",
"next-button-text": "Próximo",
"lab-results-title": "Resultados de laboratório",
Expand Down
Loading