-
Notifications
You must be signed in to change notification settings - Fork 2
Add new BloodPressureReading and LatestBloodPressureReading components. #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
e5535c6 to
ebe0c9c
Compare
ebe0c9c to
a36b194
Compare
ajmenca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty great, to me. Appreciate the separation of the Presentational component from the Containerized version that gets a specific value. Just one quick suggestion, back on PR #334, it was noted that you can add JSDoc style blocks to the top of components and then get them to render in the stories:
MyDataHelpsUI/src/components/container/BasicPointsForBadges/BasicPointsForBadges.tsx
Lines 26 to 33 in 54c84a0
| /** | |
| * Earn points for completing activities. Badges are earned once pointsPerBadge are reached. | |
| * The progress bar will fill as points are earned. When a badge is earned a celebration step | |
| * will show and the progress bar will then reset. | |
| * Activity types supported are Survey Completion, Daily device data like sleep and steps, | |
| * connecting external accounts like an EHR, Health Plan, or wearable device, | |
| * and lastly based on the participant's custom field value. | |
| */ |
MyDataHelpsUI/src/components/container/BasicPointsForBadges/BasicPointsForBadges.stories.tsx
Lines 18 to 20 in 54c84a0
| docs: { | |
| Description: <Description /> | |
| } |
I actually think this is a great feature that we're not leveraging consistently enough? In this case, it would be helpful at a glance at the stories to help describe how the Presentational component differs from the Container one.
Good idea. Done. |
|
Thanks @ajmenca. |
Overview
This branch adds a couple new components for displaying blood pressure readings. The
BloodPressureReadingpresentational component is used to render a blood pressure reading. TheLatestBloodPressureReadingcontainer component is used to load the latest blood pressure reading from across all supported device data sources and render it using theBloodPressureReadingcomponent.I also updated the combined blood pressure data provider so that it uses data collection settings and added a new v2 blood pressure data provider so I could add support for HealthConnect blood pressures.
Security
DESCRIBE BRIEFLY WHAT SECURITY RISKS YOU CONSIDERED, WHY THEY DON'T APPLY, OR HOW THEY'VE BEEN MITIGATED.
Testing
DESCRIBE YOUR TEST PLAN
Documentation
@CareEvolution/api-docs.