Skip to content

Conversation

@greinard
Copy link
Collaborator

@greinard greinard commented May 8, 2025

Overview

This branch adds a couple new components for displaying blood pressure readings. The BloodPressureReading presentational component is used to render a blood pressure reading. The LatestBloodPressureReading container component is used to load the latest blood pressure reading from across all supported device data sources and render it using the BloodPressureReading component.

I also updated the combined blood pressure data provider so that it uses data collection settings and added a new v2 blood pressure data provider so I could add support for HealthConnect blood pressures.

image

Security

Consider potential security impacts and complete the following checklist.
REMINDER: All file contents are public.

  • I have ensured no secure credentials or sensitive information remain in code, metadata, comments, etc.
    • Please verify that you double checked that .storybook/preview.js does not contain your participant access key details.
    • There are no temporary testing changes committed such as API base URLs, access tokens, print/log statements, etc.
  • These changes do not introduce any security risks, or any such risks have been properly mitigated.

DESCRIBE BRIEFLY WHAT SECURITY RISKS YOU CONSIDERED, WHY THEY DON'T APPLY, OR HOW THEY'VE BEEN MITIGATED.

  • No new security risk. This PR is just adds rendering for some additional data that is already available via our delegated endpoints.

Testing

Consider whether the changes might have device-specific behaviors (screen padding, new APIs, etc.) and check one of the following boxes:

  • This change can be adequately tested using the MDH Storybook.
  • This change requires additional testing in the MDH iOS/Android/Web apps. (Create a pre-release tag/build and test in a ViewBuilder PR.)

DESCRIBE YOUR TEST PLAN

  • A dev can comment some code to test via the Storybook, but others will require a ViewBuilder PR to fully test. I'll create one of those shortly and reference this PR.

Documentation

Consider whether there are any documentation impacts and check one of the following boxes:

  • I have added relevant Storybook updates to this PR.
  • If this feature requires a developer doc update, I have tagged @CareEvolution/api-docs.
  • This change does not impact documentation or Storybook.

@greinard greinard requested review from ajmenca, bxh and chrisnowak May 8, 2025 16:23
@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-471.d1xp2kmk6zrv44.amplifyapp.com

@greinard greinard force-pushed the LatestBloodPressureReading branch from e5535c6 to ebe0c9c Compare May 9, 2025 14:47
@greinard greinard force-pushed the LatestBloodPressureReading branch from ebe0c9c to a36b194 Compare May 9, 2025 14:49
Copy link
Collaborator

@ajmenca ajmenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty great, to me. Appreciate the separation of the Presentational component from the Containerized version that gets a specific value. Just one quick suggestion, back on PR #334, it was noted that you can add JSDoc style blocks to the top of components and then get them to render in the stories:

/**
* Earn points for completing activities. Badges are earned once pointsPerBadge are reached.
* The progress bar will fill as points are earned. When a badge is earned a celebration step
* will show and the progress bar will then reset.
* Activity types supported are Survey Completion, Daily device data like sleep and steps,
* connecting external accounts like an EHR, Health Plan, or wearable device,
* and lastly based on the participant's custom field value.
*/

I actually think this is a great feature that we're not leveraging consistently enough? In this case, it would be helpful at a glance at the stories to help describe how the Presentational component differs from the Container one.

@greinard
Copy link
Collaborator Author

Just one quick suggestion, back on PR #334, it was noted that you can add JSDoc style blocks to the top of components and then get them to render in the stories

Good idea. Done.

@greinard
Copy link
Collaborator Author

Thanks @ajmenca.

@greinard greinard merged commit ba2e957 into main May 12, 2025
0 of 3 checks passed
@greinard greinard deleted the LatestBloodPressureReading branch May 12, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants