formatMinutesForLocale: Format hours and minutes after rounding. #552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This branch updates the
formatMinutesForLocalehelper function to correct a rounding error.Previously, the minutes were being rounded after the hours had already been determined. This meant that a value of
119.5minutes would format as1hr 60m.The fix here is to round the total minutes up front, then determine the hour and minute values to use in the formatted string.
Security
No new security risk. Just adjusting the minutes display format computation to handle an edge case.
Testing
This change can be adequately tested using the updated unit tests.
Documentation
@CareEvolution/api-docs.