Customizable login button #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschramm
approved these changes
Mar 12, 2025
|
|
||
| @implementation ORK1LoginStepViewController | ||
| @implementation ORK1LoginStepViewController { | ||
| NSString *_loginButtonTitle; |
There was a problem hiding this comment.
I had to refamiliarize myself with the nuances of having an @Property declaration in the header, but doing the work manually in the .m file with a custom setter/getter :)
Member
Author
There was a problem hiding this comment.
Same 😆. Luckily ResearchKit already has several instances of this pattern to confirm I was doing the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in ResearchKit translations for login buttons is "Login", but we want to use "Log In". I opted to simply make this customizable so we can use the localized string that we already have in the MDH repo, rather than changing the translations in ResearchKit itself.
Testing
This is tested as part of https://github.com/CareEvolution/MyDataHelps-iOS/pull/1400