-
Notifications
You must be signed in to change notification settings - Fork 1
[Feat/component/create server/FLOW-22] 서버 생성 기능 구현 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/component/create-server/FLOW-22
…into feat/component/create-server/FLOW-22
❌ Deploy Preview for chatflow-project failed.
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the server creation feature with image upload support. Key changes include:
- Updating the AddServerModal to use axiosInstance for image uploads and integrating a new team creation hook.
- Refactoring TeamSidebar and ChatServer component imports/usage to reflect new file organization and functionality.
- Adding and updating team-related hooks, API calls, and type definitions for managing teams.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/view/pages/chat/components/AddServerModal.tsx | Uses new axiosInstance and useCreateTeam hook for server creation and image upload. |
| src/view/components/layout/sidebar/team/TeamSidebar.tsx | Implements a new TeamSidebar integrating dynamic team data and server addition. |
| src/view/components/layout/sidebar/components/team/ChatServer.tsx | Updates ChatServer component with an added isAdd prop for rendering the add button. |
| src/view/components/layout/TeamSidebar.tsx | Removes the legacy TeamSidebar component. |
| src/view/components/layout/LayoutWithSidebar.tsx | Updates the import path for the new TeamSidebar. |
| src/view/components/common/Icon.tsx | Simplifies the Icon component by removing width/height props. |
| src/service/feature/team/types/team.ts | Adds the Team interface. |
| src/service/feature/team/hooks/useTeamSidebar.ts | Adds team fetching and creation hooks with react-query. |
| src/service/feature/team/api/teamApi.ts | Adds API calls for team operations. |
| src/service/feature/team/ChatServer.tsx | Removes obsolete ChatServer implementation. |
| src/service/feature/common/axios/axiosInstance.ts | Updates axios interceptors to reflect improved error handling syntax. |
Comments suppressed due to low confidence (1)
src/view/components/layout/sidebar/components/team/ChatServer.tsx:23
- When 'server' is undefined and isAdd is false, the component conditionally renders the fallback 'me' element, but later also renders an element with server?.name (which will be undefined). This results in two adjacent renderings where one may be empty. Consider combining the fallback logic into a single conditional render to avoid displaying empty content.
{isAdd ? ( <Icon path='plus' className='!w-5 !h-5' /> ) : ( !server && <div className='text-center text-lg'>me</div> )}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 PR 제목
✅ 요구사항
✅ 체크리스트