add exclusion setting for domains ( related issue #353 )#383
add exclusion setting for domains ( related issue #353 )#383KMohZaid wants to merge 3 commits intoClearURLs:masterfrom
Conversation
KMohZaid
changed the title
|
related issue : #353 (wow sonarcloud, i didnt know they have this intregation for free) |
|
lol, i knew i should do something to keep 1 return url statement but lazy to do and it was feeling complex if i does and sad, i forgot to remove test console.log |
|
|
|
@KMohZaid +1 to have this merged in and released. I would love to finally have this feature in ClearURLs. It would make my life so much better. |
|
Lol I didn't notice a mistake In regex explanation, after |
(ClearURLs#383 (comment)) 1. using variable to store boolean and if any boolean is true, then return url 2. using for-of for list 3. we are using "storage" variable to store dictionary data not array, so made it "{}" from "[]" 4. "value" parameter in setData was string when case was "excludeDomains", still removed its console.log (not needed to console log it now so)
fix: 5 issues reported by sonarcloud
|
|
nice |
|
This PR is a feature to solves the #387 issue. |
No, this is just workaround. I think we should check what are tracking parameters for Google sheets domain and add rules for them. This feature will trust domain and allows unfiltered url loading |
|
@KMohZaid: Can you create a PR on Gitlab too? If it is not merged, I think it is the moment to fork this project. Linked to: |
4 participants
Problem in this PR is : I am "noob" and i don't know how to use
i18ntranslation . so we have to do it.