-
Notifications
You must be signed in to change notification settings - Fork 122
feat: make the cloudnet wrapper a java agent #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 56 files ±0 56 suites ±0 4m 34s ⏱️ +36s Results for commit b550594. ± Comparison against base commit 6043b0d. This pull request removes 37 and adds 37 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
derklaro
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: node
An issue/pull request releated to the node module code
in: wrapper
An issue/pull request releated to the wrapper module code
t: improvement
The pull request improves existing code
v: 4.X
This pull should be included in the 4.0 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having the wrapper as java agent instead of a standalone application that boots the regular application resolves issues where e.g. the application depends on SPI to get some implementation, which was not possible with the current wrapper setup.
Modification
Re-designed the wrapper to be a java agent that is attached instead of a standalone application
Result
The wrapper is an agent and we can start taking a look into sponge support again